all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager] priv daemon: create jobstate directory after the state dir
@ 2025-12-01  9:19 Lukas Wagner
  2025-12-02  0:03 ` [pdm-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2025-12-01  9:19 UTC (permalink / raw)
  To: pdm-devel

The jobstate directory is located *within* the state directory, so it
makes sense to change the order of operations such that the state
directory is actually created before the jobstate dir. This ensures that
the permissions on the state dir are set as expected.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 server/src/bin/proxmox-datacenter-privileged-api.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/server/src/bin/proxmox-datacenter-privileged-api.rs b/server/src/bin/proxmox-datacenter-privileged-api.rs
index 9b0a037b..93ad810a 100644
--- a/server/src/bin/proxmox-datacenter-privileged-api.rs
+++ b/server/src/bin/proxmox-datacenter-privileged-api.rs
@@ -63,7 +63,6 @@ fn create_directories() -> Result<(), Error> {
     let api_user = pdm_config::api_user()?;
 
     pdm_config::setup::create_configdir()?;
-    server::jobstate::create_jobstate_dir()?;
 
     pdm_config::setup::mkdir_perms(
         pdm_buildcfg::PDM_RUN_DIR,
@@ -100,6 +99,8 @@ fn create_directories() -> Result<(), Error> {
         0o755,
     )?;
 
+    server::jobstate::create_jobstate_dir()?;
+
     Ok(())
 }
 
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pdm-devel] applied: [PATCH datacenter-manager] priv daemon: create jobstate directory after the state dir
  2025-12-01  9:19 [pdm-devel] [PATCH datacenter-manager] priv daemon: create jobstate directory after the state dir Lukas Wagner
@ 2025-12-02  0:03 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-02  0:03 UTC (permalink / raw)
  To: pdm-devel, Lukas Wagner

On Mon, 01 Dec 2025 10:19:35 +0100, Lukas Wagner wrote:
> The jobstate directory is located *within* the state directory, so it
> makes sense to change the order of operations such that the state
> directory is actually created before the jobstate dir. This ensures that
> the permissions on the state dir are set as expected.
> 
> 

Applied, thanks!

[1/1] priv daemon: create jobstate directory after the state dir
      commit: 06a705b673a843e6a13504eb0a88c889f776199c


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-02  0:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01  9:19 [pdm-devel] [PATCH datacenter-manager] priv daemon: create jobstate directory after the state dir Lukas Wagner
2025-12-02  0:03 ` [pdm-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal