From: Hannes Laimer <h.laimer@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox] pve-api-types: schema2rust: handle `ref` keyword like we do `macro`
Date: Fri, 28 Nov 2025 15:25:16 +0100 [thread overview]
Message-ID: <20251128142516.276276-1-h.laimer@proxmox.com> (raw)
Firewall refs have a field named `ref`, this would trip up the
generated rust code. This fixes that.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
pve-api-types/generator-lib/Schema2Rust.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pve-api-types/generator-lib/Schema2Rust.pm b/pve-api-types/generator-lib/Schema2Rust.pm
index 52493375..2bdb33d9 100644
--- a/pve-api-types/generator-lib/Schema2Rust.pm
+++ b/pve-api-types/generator-lib/Schema2Rust.pm
@@ -127,7 +127,7 @@ sub api_to_string : prototype($$$$$) {
local $API_TYPE_POS = "$API_TYPE_POS/$key";
# We need to quote keys with hyphens or reserved keywords:
- my $safe_key = (($key =~ /-/) || ($key eq 'macro')) ? "\"$key\"" : $key;
+ my $safe_key = (($key =~ /-/) || ($key eq 'macro') || ($key eq 'ref')) ? "\"$key\"" : $key;
if (exists($API_TYPE_OVERRIDES{$API_TYPE_POS})) {
$value = $API_TYPE_OVERRIDES{$API_TYPE_POS};
@@ -172,7 +172,7 @@ sub api_to_string : prototype($$$$$) {
warn "api type extension for $API_TYPE_POS.$key already in schema, skipping\n";
next;
}
- my $safe_key = (($key =~ /-/) || ($key eq 'macro')) ? "\"$key\"" : $key;
+ my $safe_key = (($key =~ /-/) || ($key eq 'macro') || ($key eq 'ref')) ? "\"$key\"" : $key;
my $value = $extra->{$key};
print {$out} "${indent}$safe_key: $value,\n";
}
@@ -730,6 +730,7 @@ sub namify_field : prototype($) {
return 'ty' if $out eq 'type';
return 'r#macro' if $out eq 'macro';
+ return 'r#ref' if $out eq 'ref';
return $out;
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
reply other threads:[~2025-11-28 14:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128142516.276276-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.