[pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup

* [pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup
@ 2025-11-28 10:47 Dominik Csapak
  2025-11-28 18:53 ` [pdm-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-11-28 10:47 UTC (permalink / raw)
  To: pdm-devel

the changed method will only be called if the properties change and
return true if none is given. So returning true when any property
changed is already the default behavior, no need for us to implement it
again.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/pve/node/mod.rs | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/ui/src/pve/node/mod.rs b/ui/src/pve/node/mod.rs
index 66ce8dda..1fcd92eb 100644
--- a/ui/src/pve/node/mod.rs
+++ b/ui/src/pve/node/mod.rs
@@ -2,10 +2,7 @@ use std::rc::Rc;
 
 use gloo_utils::window;
 use proxmox_yew_comp::{AptPackageManager, ConsoleType, XTermJs};
-use yew::{
-    virtual_dom::{VComp, VNode},
-    Context,
-};
+use yew::virtual_dom::{VComp, VNode};
 
 use pwt::{
     css::{AlignItems, ColorScheme},
@@ -51,12 +48,6 @@ impl yew::Component for PveNodePanelComp {
         Self
     }
 
-    fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
-        let props = ctx.props();
-
-        props.remote != old_props.remote || props.node != old_props.node
-    }
-
     fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
         let props = ctx.props();
 
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread