all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 5/5] ui: pve: datacenter: add remote notes panel
Date: Fri, 28 Nov 2025 11:18:26 +0100	[thread overview]
Message-ID: <20251128101848.1580111-9-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251128101848.1580111-1-d.csapak@proxmox.com>

to have a place for that, move the remote tasks and the notes below a
tab panel, like we do for the guests and nodes.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/pve/mod.rs        |  8 ++--
 ui/src/pve/remote/mod.rs | 84 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+), 5 deletions(-)
 create mode 100644 ui/src/pve/remote/mod.rs

diff --git a/ui/src/pve/mod.rs b/ui/src/pve/mod.rs
index efe61af9..5fd964a9 100644
--- a/ui/src/pve/mod.rs
+++ b/ui/src/pve/mod.rs
@@ -26,6 +26,7 @@ use pdm_api_types::resource::{PveResource, ResourceType};
 pub mod lxc;
 pub mod node;
 pub mod qemu;
+pub mod remote;
 pub mod remote_overview;
 pub mod storage;
 pub mod utils;
@@ -33,7 +34,7 @@ pub mod utils;
 mod tree;
 use tree::PveTreeNode;
 
-use crate::{get_deep_url, remotes::RemoteTaskList};
+use crate::get_deep_url;
 
 #[derive(Debug, Eq, PartialEq, Properties)]
 pub struct PveRemote {
@@ -182,10 +183,7 @@ impl LoadableComponent for PveRemoteComp {
         let remote = &props.remote;
 
         let content: Html = match &self.view {
-            PveTreeNode::Root => Panel::new()
-                .title(tr!("Remote Tasks"))
-                .with_child(RemoteTaskList::new().remote(remote.clone()))
-                .into(),
+            PveTreeNode::Root => remote::PveRemotePanel::new(remote.clone()).into(),
             PveTreeNode::Node(node) => {
                 node::PveNodePanel::new(remote.clone(), node.node.clone()).into()
             }
diff --git a/ui/src/pve/remote/mod.rs b/ui/src/pve/remote/mod.rs
new file mode 100644
index 00000000..60ea4ade
--- /dev/null
+++ b/ui/src/pve/remote/mod.rs
@@ -0,0 +1,84 @@
+use std::rc::Rc;
+
+use proxmox_yew_comp::NotesView;
+use yew::virtual_dom::{VComp, VNode};
+
+use pwt::css::{AlignItems, ColorScheme};
+use pwt::prelude::*;
+use pwt::props::{ContainerBuilder, WidgetBuilder};
+use pwt::widget::{Fa, Row, TabBarItem, TabPanel};
+
+use crate::remotes::RemoteTaskList;
+
+#[derive(Clone, Debug, Eq, PartialEq, Properties)]
+pub struct PveRemotePanel {
+    /// The remote to show
+    pub remote: String,
+}
+
+impl PveRemotePanel {
+    pub fn new(remote: String) -> Self {
+        yew::props!(Self { remote })
+    }
+}
+
+impl From<PveRemotePanel> for VNode {
+    fn from(val: PveRemotePanel) -> Self {
+        VComp::new::<PveRemotePanelComp>(Rc::new(val), None).into()
+    }
+}
+
+struct PveRemotePanelComp;
+
+impl yew::Component for PveRemotePanelComp {
+    type Message = ();
+    type Properties = PveRemotePanel;
+
+    fn create(_ctx: &yew::Context<Self>) -> Self {
+        Self
+    }
+
+    fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
+        let props = ctx.props();
+
+        let title: Html = Row::new()
+            .gap(2)
+            .class(AlignItems::Baseline)
+            .with_child(Fa::new("building"))
+            .with_child(tr! {"Remote '{0}'", props.remote})
+            .into();
+
+        TabPanel::new()
+            .class(pwt::css::FlexFit)
+            .title(title)
+            .class(ColorScheme::Neutral)
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("tasks_view")
+                    .label(tr!("Remote Tasks"))
+                    .icon_class("fa fa-list"),
+                {
+                    let remote = props.remote.clone();
+                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
+                },
+            )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("notes_view")
+                    .label(tr!("Notes"))
+                    .icon_class("fa fa-sticky-note-o"),
+                {
+                    let remote = props.remote.clone();
+                    move |_| {
+                        NotesView::edit_property(
+                            format!("/pve/remotes/{remote}/options"),
+                            "description",
+                        )
+                        .on_submit(None)
+                        .into()
+                    }
+                },
+            )
+            .into()
+    }
+}
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2025-11-28 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 10:18 [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 0/8] ui: add remote datacenter/node notes panels Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH proxmox 1/2] pve api types: add node config get api call Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH proxmox 2/2] pve api types: add cluster options " Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH yew-comp 1/1] notes edit: hide toolbar when editing is not possible Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH datacenter-manager 1/5] server: api: add nodes config api Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH datacenter-manager 2/5] server: api: pve: add cluster options api call Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: pve: rename remote module Dominik Csapak
2025-11-28 10:18 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: pve: nodes: add panel for notes Dominik Csapak
2025-11-28 10:18 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128101848.1580111-9-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal