all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/6] ui: main: abort running task load on log out
Date: Thu, 27 Nov 2025 16:36:04 +0100	[thread overview]
Message-ID: <20251127153609.440415-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20251127153609.440415-1-s.sterz@proxmox.com>

loading currently running tasks wasn't aborted on logout. this is due
to the Loader not being dropped as the DatacenterManagerApp is always
rendered and it never drops its loader. this could trigger a race
condition between a load with a potentially expired ticket and a new
log in request. if the load returned after the login, a user would be
kicked out right after logging in again.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 ui/src/main.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/src/main.rs b/ui/src/main.rs
index 2cbc7a9..026b7ab 100644
--- a/ui/src/main.rs
+++ b/ui/src/main.rs
@@ -249,6 +249,7 @@ impl Component for DatacenterManagerApp {
             }
             Msg::Logout => {
                 //log::info!("CLEAR COOKIE");
+                self.running_tasks.abort();
                 self.remote_list_timeout = None;
                 proxmox_yew_comp::http_clear_auth();
                 self.login_info = None;
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-27 15:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 15:36 [pdm-devel] [PATCH datacenter-manager/yew-widget-toolkit 0/7] avoid more race conditions on log in Shannon Sterz
2025-11-27 15:36 ` [pdm-devel] [PATCH yew-widget-toolkit 1/1] loader: add helper to allow aborting a load Shannon Sterz
2025-11-27 18:22   ` [pdm-devel] applied: " Thomas Lamprecht
2025-11-27 15:36 ` Shannon Sterz [this message]
2025-11-27 15:36 ` [pdm-devel] [PATCH datacenter-manager 2/6] ui: main: move requests into an async pool and drop it on logout Shannon Sterz
2025-11-27 15:36 ` [pdm-devel] [PATCH datacenter-manager 3/6] ui: main: only render acl context when we are logged in Shannon Sterz
2025-11-27 15:36 ` [pdm-devel] [PATCH datacenter-manager 4/6] ui: resource tree: use an async pool for requests Shannon Sterz
2025-11-27 15:36 ` [pdm-devel] [PATCH datacenter-manager 5/6] ui: node status: handle the request via an AsyncAbortGuard Shannon Sterz
2025-11-27 15:36 ` [pdm-devel] [PATCH datacenter-manager 6/6] ui: top nav bar: use an abort guard for loading the version Shannon Sterz
2025-11-27 20:54 ` [pdm-devel] applied: [PATCH datacenter-manager/yew-widget-toolkit 0/7] avoid more race conditions on log in Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251127153609.440415-3-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal