[pve-devel] [PATCH pve-api-types] api-types: add lxc pending config, move_volume and resize api

[pve-devel] [PATCH pve-api-types] api-types: add lxc pending config, move_volume and resize api

[Dietmar Maurer]

And rename QemuPendingConfigValue to PvePendingConfigValue.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 pve-api-types/generate.pl | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/pve-api-types/generate.pl b/pve-api-types/generate.pl
index ef0d92f5..363210d4 100644
--- a/pve-api-types/generate.pl
+++ b/pve-api-types/generate.pl
@@ -126,6 +126,7 @@ Schema2Rust::generate_enum('IsRunning', {
 # We have a textual description of the default value in there, just pick the cgroupv2 one:
 Schema2Rust::register_api_override('UpdateQemuConfig', '/properties/cpuunits/default', 1024);
 Schema2Rust::register_api_override('UpdateQemuConfigAsync', '/properties/cpuunits/default', 1024);
+Schema2Rust::register_api_override('UpdateLxcConfig', '/properties/cpuunits/default', 100);
 
 Schema2Rust::register_api_override('QemuConfig', '/properties/cpuunits/default', 1024);
 Schema2Rust::register_api_override('LxcConfig', '/properties/cpuunits/default', 1024);
@@ -141,6 +142,7 @@ Schema2Rust::register_api_override('RemoteMigrateLxc', '/properties/bwlimit/defa
 
 # We have a textual description of the default value in there, simply set to undef
 Schema2Rust::register_api_override('QemuMoveDisk', '/properties/bwlimit/default', undef);
+Schema2Rust::register_api_override('LxcMoveDisk', '/properties/bwlimit/default', undef);
 
 # Token api is missing some descriptions and has textual defaults for integers
 Schema2Rust::register_api_extensions('CreateTokenResponseInfo', {
@@ -231,7 +233,7 @@ api(DELETE => '/nodes/{node}/tasks/{upid}',     'stop_task');
 
 api(GET => '/nodes/{node}/qemu', 'list_qemu', 'param-name' => 'FixmeListQemu', 'return-name' => 'VmEntry');
 api(GET => '/nodes/{node}/qemu/{vmid}/config', 'qemu_get_config', 'param-name' => 'FixmeQemuGetConfig', 'return-name' => 'QemuConfig');
-api(GET => '/nodes/{node}/qemu/{vmid}/pending', 'qemu_get_pending', 'param-name' => 'FixmeQemuGetPending', 'output-type' => 'Vec<QemuPendingConfigValue>');
+api(GET => '/nodes/{node}/qemu/{vmid}/pending', 'qemu_get_pending', 'param-name' => 'FixmeQemuGetPending', 'output-type' => 'Vec<PvePendingConfigValue>');
 api(GET => '/nodes/{node}/qemu/{vmid}/status/current', 'qemu_get_status', 'return-name' => 'QemuStatus');
 api(PUT => '/nodes/{node}/qemu/{vmid}/config', 'qemu_update_config', 'param-name' => 'UpdateQemuConfig');
 api(POST => '/nodes/{node}/qemu/{vmid}/config', 'qemu_update_config_async', 'param-name' => 'UpdateQemuConfigAsync', 'output-type' => 'Option<PveUpid>');
@@ -256,6 +258,10 @@ api(POST => '/nodes/{node}/qemu/{vmid}/remote_migrate', 'remote_migrate_qemu',
 api(GET => '/nodes/{node}/lxc',                         'list_lxc',            'param-name' => 'FixmeListLxc',      'return-name' => 'LxcEntry');
 api(GET => '/nodes/{node}/lxc/{vmid}/config',           'lxc_get_config',      'param-name' => 'FixmeLxcGetConfig', 'return-name' => 'LxcConfig');
 Schema2Rust::derive('LxcConfigNet' => 'Clone', 'PartialEq');
+api(PUT => '/nodes/{node}/lxc/{vmid}/config', 'lxc_update_config', 'param-name' => 'UpdateLxcConfig');
+api(GET => '/nodes/{node}/lxc/{vmid}/pending', 'lxc_get_pending', 'param-name' => 'FixmeLxcGetPending', 'output-type' => 'Vec<PvePendingConfigValue>');
+api(POST => '/nodes/{node}/lxc/{vmid}/move_volume', 'lxc_move_volume', 'param-name' => 'LxcMoveVolume', 'output-type' => 'PveUpid');
+api(PUT => '/nodes/{node}/lxc/{vmid}/resize', 'lxc_resize', 'param-name' => 'LxcResize', 'output-type' => 'PveUpid');
 api(GET => '/nodes/{node}/lxc/{vmid}/status/current',   'lxc_get_status',      'return-name' => 'LxcStatus');
 api(POST => '/nodes/{node}/lxc/{vmid}/status/start',    'start_lxc_async',     'output-type' => 'PveUpid', 'param-name' => 'StartLxc');
 api(POST => '/nodes/{node}/lxc/{vmid}/status/stop',     'stop_lxc_async',      'output-type' => 'PveUpid', 'param-name' => 'StopLxc');
-- 
2.47.3


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-api-types] api-types: add lxc pending config, move_volume and resize api

[Thomas Lamprecht]

Am 25.11.25 um 12:39 schrieb Dietmar Maurer:
> And rename QemuPendingConfigValue to PvePendingConfigValue.

The actual rename was either not committed or overlooked? As that type is not
generated, the generate.pl file just references it.

I now renamed it to PendingConfigValue as the "Pve" prefix does not really gains
us anything, we're already in a *pve*-api-types crate after all.

The override for the bwlimit default was on the wrong type, as for LXC we use
the term Volume over the term Disk,  thus failing compilation.

I addressed all these and pushed out the changes, but did not bump yet; please
check if that works now for your usecase.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-api-types] api-types: add lxc pending config, move_volume and resize api

[Dietmar Maurer]

works as expected. thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel