[pbs-devel] [PATCH proxmox{, -backup} v2 0/7] tuning: verify: add verify job thread options

[Nicolas Frey <n.frey@proxmox.com>]

this patch series aims to expose configuration of the number of threads
to use for reading and verifying of verify jobs through the datastore's
tuning options.

It expands on the series I sent last week [0], where @Thomas
suggested making this configurable through the tuning options too.
@Chris suggested adding a dedicated worker thread settings to the
datastore instead, which is an approach I don't have a problem with,
but I'd want some more opinions on.

If the docs should be updated to account for this change, I can either
send a follow up or do that in a v2.

Later down the line, it would also be beneficial to add the tape job
threads to these options, though that is outside of the scope of this
series.

[0] https://lore.proxmox.com/pbs-devel/5a731352-1f77-4b15-9a22-7064b70ce519@proxmox.com/T/#t

Changes since v1 (thanks Chris!):
* renamed user-facing parameters to make them less clumsy and clearer
* add the new tuning parameters to the docs
* adapt `render_tuning_options`
* cleaned up nits

proxmox:

Nicolas Frey (1):
  pbs-api-types: add default-verification-{workers,readers} to tuning
    options

 pbs-api-types/src/datastore.rs | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)


proxmox-backup:

Nicolas Frey (6):
  datastore: add new thread settings to tuning options
  verify: use tuning options' thread settings for {verify,read}-threads
  ui: tuning: make default-verification-{workers,readers} configurable
  ui: tuning: render verification threads in tuning options
  ui: verify: fetch default {read,verify} thread values from tuning
    options
  docs: tuning: document default-verification-{workers,readers}

 docs/storage.rst               |  5 +++++
 pbs-datastore/src/datastore.rs | 34 ++++++++++++++++++++++++++++++
 src/backup/verify.rs           | 14 +++++++++++--
 www/Utils.js                   | 12 +++++++++++
 www/datastore/OptionView.js    | 20 ++++++++++++++++++
 www/window/VerifyAll.js        | 38 ++++++++++++++++++++++++++++++++--
 www/window/VerifyJobEdit.js    | 37 +++++++++++++++++++++++++++++++++
 7 files changed, 156 insertions(+), 4 deletions(-)


Summary over all repositories:
  8 files changed, 170 insertions(+), 5 deletions(-)

-- 
Generated by git-murpp 0.8.1

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel