From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 2/4] chunk store: fix and expand the clear_chunk_expected_mark() docstring
Date: Mon, 24 Nov 2025 10:40:16 +0100 [thread overview]
Message-ID: <20251124094018.224661-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251124094018.224661-1-c.ebner@proxmox.com>
The sentence was grammatically wrong and did not provide to much
context on what this is used for. Fix and extend the docstring.
Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Changes since version 1:
- not present
pbs-datastore/src/chunk_store.rs | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
index f10415d1f..143848838 100644
--- a/pbs-datastore/src/chunk_store.rs
+++ b/pbs-datastore/src/chunk_store.rs
@@ -749,7 +749,12 @@ impl ChunkStore {
Ok(())
}
- /// Remove chunk as required mark by removing file the chunk store.
+ /// Remove the chunk-expected marker file from the chunk store.
+ ///
+ /// Used to remove the chunk-expected marker file during phase 2 of garbage collection. This
+ /// marker file is created during phase 1 of garbage collection in case the chunk or its zero
+ /// size marker file is not found in the chunk store, but still referenced by an index file,
+ /// flagging it as still required.
///
/// Returns true if the file was present and removed, false if the file did not exist.
pub(crate) fn clear_chunk_expected_mark(&self, digest: &[u8; 32]) -> Result<bool, Error> {
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-24 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 9:40 [pbs-devel] [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 1/4] GC: s3: " Christian Ebner
2025-11-24 9:40 ` Christian Ebner [this message]
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 3/4] chunk store: clarify chunk marker helper creates marker if missing Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 4/4] datastore: refactor common delete list logic into closure Christian Ebner
2025-11-24 12:23 ` [pbs-devel] applied: [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks Thomas Lamprecht
2025-11-24 12:51 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124094018.224661-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.