all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] verify: include namespace for group in log
Date: Thu, 20 Nov 2025 12:52:43 +0100	[thread overview]
Message-ID: <20251120115243.311895-1-h.laimer@proxmox.com> (raw)

Groups with the same name in different namespaces couldn't really be told
appart. This solves this by also printing the namespace of a group to the
log.

This came up in support.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
not super sure about the formatting, didn't want to change the
<datastore>:<group> format we use a lot. don't log for snapshots as that
would potentially add a lot of output that doesn't add much information

 src/backup/verify.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backup/verify.rs b/src/backup/verify.rs
index 734c7b30..10f54c28 100644
--- a/src/backup/verify.rs
+++ b/src/backup/verify.rs
@@ -500,8 +500,15 @@ impl VerifyWorker {
         };
 
         let snapshot_count = list.len();
+        let ns = group.backup_ns();
+        let ns_str = if ns.is_root() {
+            "/".to_string()
+        } else {
+            ns.to_string()
+        };
         info!(
-            "verify group {}:{} ({} snapshots)",
+            "verify group in '{}' - {}:{} ({} snapshots)",
+            ns_str,
             self.datastore.name(),
             group.group(),
             snapshot_count
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-11-20 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 11:52 Hannes Laimer [this message]
2025-11-20 12:34 ` Michael Köppl
2025-11-20 13:09 ` Fabian Grünbichler
2025-11-20 13:21   ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120115243.311895-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal