all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/4] ui: move pbs node overview panel from pbs::remote to pbs::node::overview
Date: Thu, 20 Nov 2025 11:36:17 +0100	[thread overview]
Message-ID: <20251120103620.128741-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251120103620.128741-1-l.wagner@proxmox.com>

So that the structure as somewhat symmetric to how the code is structure
for PVE. The code itself is also very similar to the one PVE one, in the
future we should check if we can share the implementation between both
- might not be trivial, since PVE and PBS use different types for e.g.
metrics.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 ui/src/pbs/mod.rs                          | 4 ++--
 ui/src/pbs/node/mod.rs                     | 1 +
 ui/src/pbs/{remote.rs => node/overview.rs} | 0
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 100644 ui/src/pbs/node/mod.rs
 rename ui/src/pbs/{remote.rs => node/overview.rs} (100%)

diff --git a/ui/src/pbs/mod.rs b/ui/src/pbs/mod.rs
index 04243e22..6d71bafc 100644
--- a/ui/src/pbs/mod.rs
+++ b/ui/src/pbs/mod.rs
@@ -23,12 +23,12 @@ pub use datastore::DatastorePanel;
 
 mod namespace_selector;
 
-mod remote;
+mod node;
+use node::overview::RemoteOverviewPanel;
 
 mod snapshot_list;
 pub use snapshot_list::SnapshotList;
 
-use crate::pbs::remote::RemoteOverviewPanel;
 use crate::pbs::tree::PbsTree;
 use crate::{get_deep_url, pdm_client};
 
diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
new file mode 100644
index 00000000..8468a02a
--- /dev/null
+++ b/ui/src/pbs/node/mod.rs
@@ -0,0 +1 @@
+pub(crate) mod overview;
diff --git a/ui/src/pbs/remote.rs b/ui/src/pbs/node/overview.rs
similarity index 100%
rename from ui/src/pbs/remote.rs
rename to ui/src/pbs/node/overview.rs
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-11-20 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 10:36 [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Lukas Wagner
2025-11-20 10:36 ` Lukas Wagner [this message]
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 2/4] ui: pbs: rename RemoteOverviewPanel to PbsNodeOverviewPanel Lukas Wagner
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 3/4] ui: pbs: move node overview to tab and add update tab Lukas Wagner
2025-11-20 15:52   ` Michael Köppl
2025-11-20 10:36 ` [pdm-devel] [PATCH datacenter-manager 4/4] ui: pve: rename NodePanel to PveNodePanel Lukas Wagner
2025-11-20 15:56 ` [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120103620.128741-2-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal