From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] Revert "fix #6815: ui: resource tree: update tag colors properly"
Date: Tue, 18 Nov 2025 14:35:11 +0100 [thread overview]
Message-ID: <20251118133517.2540651-1-d.csapak@proxmox.com> (raw)
This reverts commit 952a4f615731c3de0351c94b83bd97340c7e7798.
Since we moved the text rendering to a renderer instead of overwriting
the 'text' property on adding the elements to the tree, this fix is
not necessary anymore since the renderer has the correct information
already.
This also wrongly rendered the guest entries in the tag view with their
'groupRenderer' instead of their normal text (vmid + name).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index b55f124a..097f1cbb 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -611,7 +611,7 @@ Ext.define('PVE.tree.ResourceTree', {
me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
me.store.getRootNode().cascadeBy({
before: function (node) {
- if (node.data.groupbyid || node.data.tags) {
+ if (node.data.groupbyid) {
node.beginEdit();
let info = node.data;
me.setIconCls(info);
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-11-18 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 13:35 Dominik Csapak [this message]
2025-11-18 14:14 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118133517.2540651-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.