From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager 4/7] sim: hardware: fix ha resource existence check in set_static_service_stats
Date: Mon, 17 Nov 2025 18:21:03 +0100 [thread overview]
Message-ID: <20251117172147.533969-5-d.kral@proxmox.com> (raw)
In-Reply-To: <20251117172147.533969-1-d.kral@proxmox.com>
Otherwise this prevents a HA resource to be created, e.g. through the
pve-ha-simulator, as the static service stats for new HA resources is
set with this method.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
src/PVE/HA/Sim/Hardware.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 9bc753dd..a1381b78 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -181,8 +181,10 @@ sub set_service_state {
sub set_static_service_stats {
my ($self, $sid, $new_stats) = @_;
+ my $conf = $self->read_service_config();
+ die "no such service '$sid'" if !$conf->{$sid};
+
my $stats = $self->read_static_service_stats();
- die "no such service '$sid'" if !$stats->{$sid};
if (my $memory = $new_stats->{maxmem}) {
print "setting $sid memory to $memory\n" if $memory != $stats->{$sid}->{maxmem};
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:20 [pve-devel] [PATCH ha-manager 0/7] Some pve-ha-simulator fixups Daniel Kral
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 1/7] sim: hardware: remove service default groups Daniel Kral
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 2/7] sim: fix read and write to static service stats' maxmem Daniel Kral
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 3/7] sim: hardware: initialize default fallback static_service_stats Daniel Kral
2025-11-17 17:21 ` Daniel Kral [this message]
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 5/7] sim: hardware: do not print stat changes in set_static_service_stats Daniel Kral
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 6/7] sim: hardware: delete static service stats on service deletion Daniel Kral
2025-11-17 17:21 ` [pve-devel] [PATCH ha-manager 7/7] d/rules: add new PVE dependencies from PVE::Tools to pve-ha-simulator Daniel Kral
2025-11-17 21:37 ` [pve-devel] applied: [PATCH ha-manager 0/7] Some pve-ha-simulator fixups Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117172147.533969-5-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.