From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 3/4] api: storage status: add optional OCI image filename parameter
Date: Mon, 17 Nov 2025 18:13:16 +0100 [thread overview]
Message-ID: <20251117171528.262443-4-f.schauer@proxmox.com> (raw)
In-Reply-To: <20251117171528.262443-1-f.schauer@proxmox.com>
Give the user the ability to choose a custom destination file name for
the OCI image.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
src/PVE/API2/Storage/Status.pm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 9fb6141..16436a3 100644
--- a/src/PVE/API2/Storage/Status.pm
+++ b/src/PVE/API2/Storage/Status.pm
@@ -933,6 +933,13 @@ __PACKAGE__->register_method({
. '(?:\.(?:[a-zA-Z\d]|[a-zA-Z\d][a-zA-Z\d-]*[a-zA-Z\d]))*(?::\d+)?/)?[a-z\d]+'
. '(?:/[a-z\d]+(?:(?:(?:[._]|__|[-]*)[a-z\d]+)+)?)*:\w[\w.-]{0,127}$',
},
+ filename => {
+ description =>
+ "Custom destination file name of the OCI image. Caution: This will be normalized!",
+ optional => 1,
+ maxLength => 255,
+ type => 'string',
+ },
},
},
returns => {
@@ -959,7 +966,8 @@ __PACKAGE__->register_method({
die "storage '$storage' is not configured for content-type 'vztmpl'\n"
if !$scfg->{content}->{vztmpl};
- my $filename = PVE::Storage::normalize_content_filename($reference) . ".tar";
+ my $filename =
+ PVE::Storage::normalize_content_filename($param->{filename} // $reference) . ".tar";
my $tmp_filename = "$filename.tmp.$$";
my $path = PVE::Storage::get_vztmpl_dir($cfg, $storage);
PVE::Storage::activate_storage($cfg, $storage);
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:13 [pve-devel] [PATCH storage 0/4] OCI registry pull fixes Filip Schauer
2025-11-17 17:13 ` [pve-devel] [PATCH storage 1/4] api: storage status: pull OCI image to temporary file Filip Schauer
2025-11-17 17:13 ` [pve-devel] [PATCH storage 2/4] api: storage status: do not pull OCI image if file already exists Filip Schauer
2025-11-17 17:13 ` Filip Schauer [this message]
2025-11-17 18:58 ` [pve-devel] [PATCH storage 3/4] api: storage status: add optional OCI image filename parameter Filip Schauer
2025-11-17 17:13 ` [pve-devel] [PATCH storage 4/4] api: storage status: oci-registry-pull: fix incomplete reference regex Filip Schauer
2025-11-17 20:56 ` [pve-devel] applied: [PATCH storage 0/4] OCI registry pull fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117171528.262443-4-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.