[pdm-devel] [PATCH datacenter-manager] remote tasks: correctly filter out foreign running PBS tasks

[pdm-devel] [PATCH datacenter-manager] remote tasks: correctly filter out foreign running PBS tasks

[Lukas Wagner]

At the moment, only tasks started by PDM will ever show up as 'active' -
mostly to avoid having to regularly poll foreign (as in, not started by
PDM) tasks. If we included running tasks in the task cache, they could
appear as 'stuck' for up to one poll interval, even if they ran only for
a couple of seconds.

This commit fixes a mistake when checking whether the task is still
running or not. Before, we *only* included running tasks, which is the
opposite of what we want.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
index 92f0f241..d3c8395e 100644
--- a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
+++ b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
@@ -301,7 +301,7 @@ async fn fetch_tasks_from_single_node(
                 .await?
                 .into_iter()
                 .filter_map(|task| {
-                    if task.endtime.is_none() {
+                    if task.endtime.is_some() {
                         // We only care about finished tasks.
                         Some(map_pbs_task(task, remote.id.clone()))
                     } else {
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] remote tasks: correctly filter out foreign running PBS tasks

[Thomas Lamprecht]

On Mon, 17 Nov 2025 16:35:10 +0100, Lukas Wagner wrote:
> At the moment, only tasks started by PDM will ever show up as 'active' -
> mostly to avoid having to regularly poll foreign (as in, not started by
> PDM) tasks. If we included running tasks in the task cache, they could
> appear as 'stuck' for up to one poll interval, even if they ran only for
> a couple of seconds.
> 
> This commit fixes a mistake when checking whether the task is still
> running or not. Before, we *only* included running tasks, which is the
> opposite of what we want.
> 
> [...]

Applied, thanks!

[1/1] remote tasks: correctly filter out foreign running PBS tasks
      commit: 6247ff3c76b439000cc4533b98f9f707a3ad7568


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel