all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH container] ui: lxc: allow empty environment variables
@ 2025-11-17 15:23 Filip Schauer
  2025-11-17 17:04 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Filip Schauer @ 2025-11-17 15:23 UTC (permalink / raw)
  To: pve-devel

Allow configuring empty environment variables in the Web UI, matching
the changes in pve-container 9a5f5ce5cfdb ("config: allow empty
environment variables")

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 www/manager6/lxc/EnvEdit.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/www/manager6/lxc/EnvEdit.js b/www/manager6/lxc/EnvEdit.js
index 673729fe..c32d4b1b 100644
--- a/www/manager6/lxc/EnvEdit.js
+++ b/www/manager6/lxc/EnvEdit.js
@@ -50,7 +50,6 @@ Ext.define('PVE.lxc.EnvVariableField', {
         },
         formulas: {
             valueEmpty: (get) => !get('value')?.length,
-            nameEmpty: (get) => !get('name')?.length,
         },
     },
 
@@ -75,7 +74,7 @@ Ext.define('PVE.lxc.EnvVariableField', {
             xtype: 'proxmoxtextfield',
             emptyText: gettext('Value'),
             bind: {
-                allowBlank: '{nameEmpty}',
+                allowBlank: true,
                 value: '{value}',
             },
             submitValue: false,
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH container] ui: lxc: allow empty environment variables
  2025-11-17 15:23 [pve-devel] [PATCH container] ui: lxc: allow empty environment variables Filip Schauer
@ 2025-11-17 17:04 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-17 17:04 UTC (permalink / raw)
  To: pve-devel, Filip Schauer

On Mon, 17 Nov 2025 16:23:35 +0100, Filip Schauer wrote:
> Allow configuring empty environment variables in the Web UI, matching
> the changes in pve-container 9a5f5ce5cfdb ("config: allow empty
> environment variables")
> 
> 

Applied, thanks!

I squashed in a change that drops the bogus fixed binding to true though, if,
that allowBlank config would have needed to move out from the bind: {} one to
the top-level config of that field, but it's the default anyway.

[1/1] ui: lxc: allow empty environment variables
      commit: e71bb0bce664204fa46cab26e7fc15b1083415b5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-17 17:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 15:23 [pve-devel] [PATCH container] ui: lxc: allow empty environment variables Filip Schauer
2025-11-17 17:04 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal