all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] www: sdn: improve naming of vm network device in bridge view
Date: Mon, 17 Nov 2025 15:47:53 +0100	[thread overview]
Message-ID: <20251117144755.199563-1-g.goller@proxmox.com> (raw)

When selecting a bridge we show all the ports and also decode the
firewall bridge port name. The name contaians the vmid and the vm
network device index. If we apply
https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
the full interface name will be shown (`net{index}`), so this is a
better name for the column.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---

Changelog v2, thanks @Thomas:
 * Change from "VM Network Device" -> "Guest Network Device" to be CT/VM
   generic.

 www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
index 600b23b0a8f8..8075f25b0851 100644
--- a/www/manager6/sdn/ZoneBridgesPanel.js
+++ b/www/manager6/sdn/ZoneBridgesPanel.js
@@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
             dataIndex: 'vmid',
         },
         {
-            text: gettext('Network Device Index'),
+            text: gettext('Guest Network Device'),
             flex: 1,
             sortable: true,
             dataIndex: 'index',
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-11-17 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 14:47 Gabriel Goller [this message]
2025-11-17 14:52 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117144755.199563-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal