[pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view

[pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view

[Gabriel Goller]

When selecting a bridge we show all the ports and also decode the
firewall bridge port name. The name contaians the vmid and the vm
network device index. If we apply
https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
the full interface name will be shown (`net{index}`), so this is a
better name for the column.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
index 600b23b0a8f8..f89f7956434a 100644
--- a/www/manager6/sdn/ZoneBridgesPanel.js
+++ b/www/manager6/sdn/ZoneBridgesPanel.js
@@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
             dataIndex: 'vmid',
         },
         {
-            text: gettext('Network Device Index'),
+            text: gettext('VM Network Device'),
             flex: 1,
             sortable: true,
             dataIndex: 'index',
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view

[Thomas Lamprecht]

Am 17.11.25 um 15:03 schrieb Gabriel Goller:
> When selecting a bridge we show all the ports and also decode the
> firewall bridge port name. The name contaians the vmid and the vm
> network device index. If we apply
> https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
> the full interface name will be shown (`net{index}`), so this is a
> better name for the column.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
> index 600b23b0a8f8..f89f7956434a 100644
> --- a/www/manager6/sdn/ZoneBridgesPanel.js
> +++ b/www/manager6/sdn/ZoneBridgesPanel.js
> @@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
>              dataIndex: 'vmid',
>          },
>          {
> -            text: gettext('Network Device Index'),
> +            text: gettext('VM Network Device'),

Is this really limited to VMs or can CTs also be shown? For the latter we
might want to use "Guest Network Device"

>              flex: 1,
>              sortable: true,
>              dataIndex: 'index',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view

[Gabriel Goller]

On 17.11.2025 15:25, Thomas Lamprecht wrote:
> Am 17.11.25 um 15:03 schrieb Gabriel Goller:
> > When selecting a bridge we show all the ports and also decode the
> > firewall bridge port name. The name contaians the vmid and the vm
> > network device index. If we apply
> > https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
> > the full interface name will be shown (`net{index}`), so this is a
> > better name for the column.
> > 
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> >  www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
> > index 600b23b0a8f8..f89f7956434a 100644
> > --- a/www/manager6/sdn/ZoneBridgesPanel.js
> > +++ b/www/manager6/sdn/ZoneBridgesPanel.js
> > @@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
> >              dataIndex: 'vmid',
> >          },
> >          {
> > -            text: gettext('Network Device Index'),
> > +            text: gettext('VM Network Device'),
> 
> Is this really limited to VMs or can CTs also be shown? For the latter we
> might want to use "Guest Network Device"

CTs can also be shown. Agree, I'll send a new patch!

We also show "VMID" in the other column is that fine for for CTs?

> >              flex: 1,
> >              sortable: true,
> >              dataIndex: 'index',
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view

[Thomas Lamprecht]

Am 17.11.25 um 15:29 schrieb Gabriel Goller:
>>> -            text: gettext('Network Device Index'),
>>> +            text: gettext('VM Network Device'),
>> Is this really limited to VMs or can CTs also be shown? For the latter we
>> might want to use "Guest Network Device"
> CTs can also be shown. Agree, I'll send a new patch!

Thx!

> We also show "VMID" in the other column is that fine for for CTs?

It's a good question, for that we actually use CTID if we're in a context
were we definitively know that it's a CT. For the common case where we
talk about both we most often keep using VMID for that term, mostly
because nobody had a better idea, and it _is_ a shared ID space, so using
different terms for that might also have its disadvantages.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel