[pve-devel] [PATCH manager 1/1] fix: ha: set ha-managed param default and unchecked value to undefined

["Michael Köppl" <m.koeppl@proxmox.com>]

This avoids sending the parameter with the default value when it's not
necessary, since the API already defines the param as optional and
assigns a default value of 0.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
Thanks to @Friedrich for bringing this to my attention. A case where
this occurs is in clusters where at least one of the nodes does not yet
support the ha-managed param and a VM is created on that node from the
web UI of a node that already supports it. Although in general it can
probably be expected that all nodes should be upgraded to a new version,
this avoids failing the CreateWizard dialog entirely for cases where the
"Add to HA" checkbox wasn't even checked at basically no cost because
the API already defines a default value of 0 and considers the param
optional.

 www/manager6/lxc/CreateWizard.js  | 4 ++--
 www/manager6/qemu/CreateWizard.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index f35709f14..024536c58 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -85,8 +85,8 @@ Ext.define('PVE.lxc.CreateWizard', {
                 {
                     xtype: 'proxmoxcheckbox',
                     name: 'ha-managed',
-                    uncheckedValue: 0,
-                    defaultValue: 0,
+                    uncheckedValue: undefined,
+                    defaultValue: undefined,
                     fieldLabel: gettext('Add to HA'),
                 },
             ],
diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index e0c56bc0b..564ca1176 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -99,8 +99,8 @@ Ext.define('PVE.qemu.CreateWizard', {
                 {
                     xtype: 'proxmoxcheckbox',
                     name: 'ha-managed',
-                    uncheckedValue: 0,
-                    defaultValue: 0,
+                    uncheckedValue: undefined,
+                    defaultValue: undefined,
                     fieldLabel: gettext('Add to HA'),
                 },
             ],
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel