all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: lxc options: fix rendering default value tty count in edit window
@ 2025-11-17 11:22 Dominik Csapak
  2025-11-17 12:31 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-11-17 11:22 UTC (permalink / raw)
  To: pve-devel

If the default is set, the edit window would always pre-fill the value
'2' instead of leaving the field empty. Fix that by removing the
manually set 'value' property.

Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
replaces the second half of this patch
(by simply dropping the first half):
https://lore.proxmox.com/pve-devel/20251117092110.628324-1-d.csapak@proxmox.com/

 www/manager6/lxc/Options.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 6cc2e2b4..4a22d38d 100644
--- a/www/manager6/lxc/Options.js
+++ b/www/manager6/lxc/Options.js
@@ -90,7 +90,6 @@ Ext.define('PVE.lxc.Options', {
                               name: 'tty',
                               minValue: 0,
                               maxValue: 6,
-                              value: 2,
                               fieldLabel: gettext('TTY count'),
                               emptyText: gettext('Default'),
                               deleteEmpty: true,
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: lxc options: fix rendering default value tty count in edit window
  2025-11-17 11:22 [pve-devel] [PATCH manager] ui: lxc options: fix rendering default value tty count in edit window Dominik Csapak
@ 2025-11-17 12:31 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-17 12:31 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Mon, 17 Nov 2025 12:22:54 +0100, Dominik Csapak wrote:
> If the default is set, the edit window would always pre-fill the value
> '2' instead of leaving the field empty. Fix that by removing the
> manually set 'value' property.
> 
> 

Applied, thanks!

[1/1] ui: lxc options: fix rendering default value tty count in edit window
      commit: c208c440603fa156f2952d9cfd5acb8d98c01dfa


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-17 12:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 11:22 [pve-devel] [PATCH manager] ui: lxc options: fix rendering default value tty count in edit window Dominik Csapak
2025-11-17 12:31 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal