all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: lxc options: fix rendering default value tty count in edit window
Date: Mon, 17 Nov 2025 12:22:54 +0100	[thread overview]
Message-ID: <20251117112334.1400372-1-d.csapak@proxmox.com> (raw)

If the default is set, the edit window would always pre-fill the value
'2' instead of leaving the field empty. Fix that by removing the
manually set 'value' property.

Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
replaces the second half of this patch
(by simply dropping the first half):
https://lore.proxmox.com/pve-devel/20251117092110.628324-1-d.csapak@proxmox.com/

 www/manager6/lxc/Options.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 6cc2e2b4..4a22d38d 100644
--- a/www/manager6/lxc/Options.js
+++ b/www/manager6/lxc/Options.js
@@ -90,7 +90,6 @@ Ext.define('PVE.lxc.Options', {
                               name: 'tty',
                               minValue: 0,
                               maxValue: 6,
-                              value: 2,
                               fieldLabel: gettext('TTY count'),
                               emptyText: gettext('Default'),
                               deleteEmpty: true,
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-11-17 11:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 11:22 Dominik Csapak [this message]
2025-11-17 12:31 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117112334.1400372-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal