From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: bulk actions: don't try to reset non-existing 'vmidfilter'
Date: Mon, 17 Nov 2025 11:02:08 +0100 [thread overview]
Message-ID: <20251117100336.894345-1-d.csapak@proxmox.com> (raw)
there never was a field with the id 'vmidfilter', so it was either a
left over from a previous attempt, or a copy&paste mistake.
It does not fix any behavior, since it was the last thing to be done in
the function anyway, but it prevents an exception/error log in the console.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
the diff does it not make it obvious, but it's just removing the 'vmid'
from the list. The linting/formatting rules change it afterwards.
www/manager6/window/BulkAction.js | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index a6f90750..e51677e2 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -219,18 +219,11 @@ Ext.define('PVE.window.BulkAction', {
let clearFilters = function () {
me.down('#namefilter').setValue('');
- [
- 'name',
- 'status',
- 'pool',
- 'type',
- 'hastate',
- 'includetag',
- 'excludetag',
- 'vmid',
- ].forEach((filter) => {
- me.down(`#${filter}filter`).setValue('');
- });
+ ['name', 'status', 'pool', 'type', 'hastate', 'includetag', 'excludetag'].forEach(
+ (filter) => {
+ me.down(`#${filter}filter`).setValue('');
+ },
+ );
};
let filterChange = function () {
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-11-17 10:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117100336.894345-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.