[pve-devel] [PATCH manager] ui: lxc options: fix rendering default and '0' value for tty count

[Dominik Csapak <d.csapak@proxmox.com>]

if '0' was entered, the options grid would show an empty line. Fix that
by adding a renderer that checks if the value is a number.

If the default is set, the edit window would always pre-fill the value
'2' instead of leaving the field empty. Fix that by removing the
manually set 'value' property.

Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/lxc/Options.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index 6cc2e2b4..0acb88f4 100644
--- a/www/manager6/lxc/Options.js
+++ b/www/manager6/lxc/Options.js
@@ -81,6 +81,7 @@ Ext.define('PVE.lxc.Options', {
             tty: {
                 header: gettext('TTY count'),
                 defaultValue: 2,
+                renderer: (value) => (Ext.isNumber(value) ? value : '2'),
                 editor: caps.vms['VM.Config.Options']
                     ? {
                           xtype: 'proxmoxWindowEdit',
@@ -90,7 +91,6 @@ Ext.define('PVE.lxc.Options', {
                               name: 'tty',
                               minValue: 0,
                               maxValue: 6,
-                              value: 2,
                               fieldLabel: gettext('TTY count'),
                               emptyText: gettext('Default'),
                               deleteEmpty: true,
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel