From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/6] interface name pinning followups
Date: Thu, 13 Nov 2025 14:49:48 +0100 [thread overview]
Message-ID: <20251113135023.1038305-1-c.heiss@proxmox.com> (raw)
Some small followups for the initial name pinning support [0].
First and foremost makes the interface name checks a bit stricter, to
comply with our `pve-iface` schema - as reported by Stoiko [1]. Thanks!
Patch #4 & #5 exclude non-physical interfaces from being shown in the
pinning dialog in the GUI and TUI, respectively. While this does change
anything for normal bare-metal installation, it is a) a bit of
future-proofing and b) improves developer/testing experience a bit, as
these interfaces should never be available for pinning anyway.
[0] https://lore.proxmox.com/pve-devel/20251111140014.1443471-1-c.heiss@proxmox.com/
[1] https://lore.proxmox.com/pve-devel/20251111181216.3c1ca6a0@rosa.proxmox.com/
Diffstat
========
Christoph Heiss (6):
sys: net: pinning: make interface name checks stricter
common: pinning: make interface name checks stricter
test: validate-link-pin-map: give all tests a name
gui: network: only display pinnable devices in pinning options dialog
tui: network: only display pinnable devices in pinning options dialog
tree-wide: run cargo fmt
Proxmox/Install.pm | 9 +--
Proxmox/Install/RunEnv.pm | 12 ++-
Proxmox/Sys/Net.pm | 35 +++------
proxinstall | 13 +++-
.../src/bin/proxmox-auto-installer.rs | 7 +-
proxmox-auto-installer/src/utils.rs | 15 ++--
.../src/fetch_plugins/http.rs | 7 +-
.../src/fetch_plugins/partition.rs | 7 +-
proxmox-installer-common/src/lib.rs | 7 +-
proxmox-installer-common/src/options.rs | 77 ++++++++++++++-----
proxmox-installer-common/src/setup.rs | 33 ++++----
proxmox-tui-installer/src/main.rs | 7 +-
proxmox-tui-installer/src/views/network.rs | 33 +++++---
test/validate-link-pin-map.pl | 34 ++++++--
14 files changed, 189 insertions(+), 107 deletions(-)
--
2.51.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-11-13 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 13:49 Christoph Heiss [this message]
2025-11-13 13:49 ` [pve-devel] [PATCH installer 1/6] sys: net: pinning: make interface name checks stricter Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 2/6] common: " Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 3/6] test: validate-link-pin-map: give all tests a name Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 4/6] gui: network: only display pinnable devices in pinning options dialog Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 5/6] tui: " Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 6/6] tree-wide: run cargo fmt Christoph Heiss
2025-11-13 20:00 ` [pve-devel] applied: [PATCH installer 0/6] interface name pinning followups Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113135023.1038305-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.