all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v5 07/11] api: resources: status: add support for view parameter
Date: Thu, 13 Nov 2025 13:16:40 +0100	[thread overview]
Message-ID: <20251113121644.236005-8-l.wagner@proxmox.com> (raw)
In-Reply-To: <20251113121644.236005-1-l.wagner@proxmox.com>

A view allows one to get filtered subset of all resources, based on
filter rules defined in a config file. View integrate with the
permission system - if a user has permissions on /view/{view-id}, then
these privileges are transitively applied to all resources which are
matched by the rules. All other permission checks are replaced if
requesting data through a view.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
---
 server/src/api/resources.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index abb75503..7ad3e168 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -425,6 +425,10 @@ pub(crate) async fn get_resources_impl(
                 default: 30,
                 optional: true,
             },
+            view: {
+                schema: VIEW_ID_SCHEMA,
+                optional: true,
+            },
         }
     },
     returns: {
@@ -438,10 +442,11 @@ pub(crate) async fn get_resources_impl(
 /// Return the amount of configured/seen resources by type
 pub async fn get_status(
     max_age: u64,
+    view: Option<String>,
     rpcenv: &mut dyn RpcEnvironment,
 ) -> Result<ResourcesStatus, Error> {
     let remotes_with_resources =
-        get_resources_impl(max_age, None, None, None, Some(rpcenv)).await?;
+        get_resources_impl(max_age, None, None, view.as_deref(), Some(rpcenv)).await?;
     let mut counts = ResourcesStatus::default();
     for remote_with_resources in remotes_with_resources {
         if let Some(err) = remote_with_resources.error {
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

  parent reply	other threads:[~2025-11-13 12:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 12:16 [pdm-devel] [PATCH datacenter-manager v5 00/11] backend implementation for view filters Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 01/11] pdm-api-types: views: add ViewConfig type Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 02/11] pdm-config: views: add support for views Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 03/11] acl: add '/view' and '/view/{view-id}' as allowed ACL paths Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 04/11] views: add implementation for view resource filtering Lukas Wagner
2025-11-13 19:54   ` Thomas Lamprecht
2025-11-14 13:25     ` Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 05/11] api: resources: list: add support for view parameter Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 06/11] api: resources: top entities: " Lukas Wagner
2025-11-13 12:16 ` Lukas Wagner [this message]
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 08/11] api: subscription status: " Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 09/11] api: remote-tasks: " Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 10/11] pdm-client: resource list: add " Lukas Wagner
2025-11-13 12:16 ` [pdm-devel] [PATCH datacenter-manager v5 11/11] pdm-client: top entities: " Lukas Wagner
2025-11-13 14:42 ` [pdm-devel] applied: [PATCH datacenter-manager v5 00/11] backend implementation for view filters Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251113121644.236005-8-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal