From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 1/6] api: datastore: fix typo in helper function name
Date: Wed, 12 Nov 2025 17:36:19 +0100 [thread overview]
Message-ID: <20251112163624.691139-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251112163624.691139-1-c.ebner@proxmox.com>
substituting `maintanance` with `maintenance`
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1:
- not present in previous version
src/api2/admin/datastore.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 6e269ef95..e81985169 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -2548,7 +2548,7 @@ pub fn mount(store: String, rpcenv: &mut dyn RpcEnvironment) -> Result<Value, Er
Ok(json!(upid))
}
-fn expect_maintanance_unmounting(
+fn expect_maintenance_unmounting(
store: &str,
) -> Result<(pbs_config::BackupLockGuard, DataStoreConfig), Error> {
let lock = pbs_config::datastore::lock_config()?;
@@ -2590,7 +2590,7 @@ fn do_unmount_device(
let mut aborted = false;
while active_operations.read + active_operations.write > 0 {
if let Some(worker) = worker {
- if worker.abort_requested() || expect_maintanance_unmounting(&datastore.name).is_err() {
+ if worker.abort_requested() || expect_maintenance_unmounting(&datastore.name).is_err() {
aborted = true;
break;
}
@@ -2608,7 +2608,7 @@ fn do_unmount_device(
}
if aborted || worker.is_some_and(|w| w.abort_requested()) {
- let _ = expect_maintanance_unmounting(&datastore.name)
+ let _ = expect_maintenance_unmounting(&datastore.name)
.inspect_err(|e| warn!("maintenance mode was not as expected: {e}"))
.and_then(|(lock, config)| {
unset_maintenance(lock, config)
@@ -2616,7 +2616,7 @@ fn do_unmount_device(
});
bail!("aborted, due to user request");
} else {
- let (lock, config) = expect_maintanance_unmounting(&datastore.name)?;
+ let (lock, config) = expect_maintenance_unmounting(&datastore.name)?;
crate::tools::disks::unmount_by_mountpoint(Path::new(&mount_point))?;
unset_maintenance(lock, config)
.map_err(|e| format_err!("could not reset maintenance mode: {e}"))?;
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-12 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 16:36 [pbs-devel] [PATCH proxmox-backup v2 0/6] wait for active operations to finish before s3 refresh Christian Ebner
2025-11-12 16:36 ` Christian Ebner [this message]
2025-11-12 16:36 ` [pbs-devel] [PATCH proxmox-backup v2 2/6] api: admin: make expected maintenance type helper generic over type Christian Ebner
2025-11-12 16:36 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] api: admin: factor out busy waiting on active operations Christian Ebner
2025-11-13 8:15 ` Fabian Grünbichler
2025-11-13 8:38 ` Christian Ebner
2025-11-12 16:36 ` [pbs-devel] [PATCH proxmox-backup v2 4/6] api: admin: factor out locking and maintenance mode clearing Christian Ebner
2025-11-13 8:18 ` Fabian Grünbichler
2025-11-13 8:43 ` Christian Ebner
2025-11-13 9:08 ` Fabian Grünbichler
2025-11-13 9:11 ` Christian Ebner
2025-11-12 16:36 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] datastore: s3 refresh: set/unset maintenance mode in api handler Christian Ebner
2025-11-12 16:36 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] api: datastore: wait for active operations to clear before s3 refresh Christian Ebner
2025-11-13 8:15 ` Fabian Grünbichler
2025-11-13 9:03 ` Christian Ebner
2025-11-13 8:20 ` [pbs-devel] partially-applied: [PATCH proxmox-backup v2 0/6] wait for active operations to finish " Fabian Grünbichler
2025-11-13 14:23 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112163624.691139-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.