From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v3 1/4] api: syncjob: correctly update/delete 'unmount-on-done' field
Date: Wed, 12 Nov 2025 13:05:12 +0100 [thread overview]
Message-ID: <20251112120515.145480-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20251112120515.145480-1-h.laimer@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/api2/config/sync.rs | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs
index 358409b5..dff447cb 100644
--- a/src/api2/config/sync.rs
+++ b/src/api2/config/sync.rs
@@ -341,6 +341,8 @@ pub enum DeletableProperty {
VerifiedOnly,
/// Delete the run_on_mount property,
RunOnMount,
+ /// Delete the unmount_on_done property,
+ UnmountOnDone,
/// Delete the sync_direction property,
SyncDirection,
}
@@ -463,6 +465,9 @@ pub fn update_sync_job(
DeletableProperty::RunOnMount => {
data.run_on_mount = None;
}
+ DeletableProperty::UnmountOnDone => {
+ data.unmount_on_done = None;
+ }
DeletableProperty::SyncDirection => {
data.sync_direction = None;
}
@@ -515,6 +520,12 @@ pub fn update_sync_job(
if let Some(run_on_mount) = update.run_on_mount {
data.run_on_mount = Some(run_on_mount);
}
+ if let Some(unmount_on_done) = update.unmount_on_done {
+ if unmount_on_done && data.run_on_mount != Some(true) {
+ bail!("'unmount-on-done' can only be set when 'run-on-mount' is enabled");
+ }
+ data.unmount_on_done = Some(unmount_on_done);
+ }
if let Some(sync_direction) = update.sync_direction {
data.sync_direction = Some(sync_direction);
}
@@ -692,6 +703,7 @@ acl:1:/remote/remote1/remotestore1:write@pbs:RemoteSyncOperator
encrypted_only: None,
verified_only: None,
run_on_mount: None,
+ unmount_on_done: None,
sync_direction: None, // use default
};
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-12 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 12:05 [pbs-devel] [PATCH proxmox{, -backup} v3 0/5] unmount datastores after sync job Hannes Laimer
2025-11-12 12:05 ` [pbs-devel] [PATCH proxmox v3 1/1] pbs-api-types: add 'unmount-on-done' field to sync job config Hannes Laimer
2025-11-14 21:36 ` [pbs-devel] applied: " Thomas Lamprecht
2025-11-12 12:05 ` Hannes Laimer [this message]
2025-11-12 12:05 ` [pbs-devel] [PATCH proxmox-backup v3 2/4] api: datastore: auto-unmount after mount-triggered sync Hannes Laimer
2025-11-12 12:05 ` [pbs-devel] [PATCH proxmox-backup v3 3/4] ui: add 'unmount-on-done' field to SyncJobEdit window Hannes Laimer
2025-11-12 12:05 ` [pbs-devel] [PATCH proxmox-backup v3 4/4] docs: add section about `unmount-on-done` Hannes Laimer
2025-11-14 22:15 ` [pbs-devel] [PATCH proxmox{, -backup} v3 0/5] unmount datastores after sync job Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112120515.145480-3-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.