[pve-devel] [PATCH proxmox_login_manager v2 0/4] fix #6983: ui: make cosmetic changes inside the login screen

[Shan Shaji <s.shaji@proxmox.com>]

This patch series fixes the issues recieved as feedback after testing
the IOS Test Flight build.

- when adding a remote the continue button is initially submit-able, even 
  though the "Origin" field is empty. taping continue will shop an error message and
  gray out the button. Fixed the issue by disabling the button by default.
- In portrait mode the margins around the "Origin" field are bit tight.
  Fixed the issue by adding more padding around the form.
- In landscape mode when adding a remote once the "Origin" field is
  selected, the top bar becomes a slightly different shade of blue. Fixed
  the issue by removing the app bar and stacked the close button.

History
=======

changes since v1:
- The Continue button was disabled even though the Origin field had a
  value. In v1, I disabled the button by default so that it would only be
  enabled after successful form validation. However, when saved
  credentials already exist and tried to log in with those credentials
  (with the SSL toggle not disabled), the Origin field UI is displayed on
  the login screen. Since the button was disabled by default even though the
  Origin field contained value, i had to edit the field to enable the button 
  again. To fix this, the button will be enabled if the origin value is not empty.
- In v1, the overlay loading indicator was hiding the Close button, 
  making it impossible to close the loading animation. To fix this, the
  Close button is now stacked above the overlay loading indicator.


Shan Shaji (4):
  fix: ui: disable continue button by default in login form
  fix: ui: add more padding around the form in portrait mode
  fix: ui: remove app bar and stack the close button on body
  cleanup: run dart format command to fix formatting

 lib/proxmox_login_form.dart | 80 ++++++++++++++++++++-----------------
 1 file changed, 43 insertions(+), 37 deletions(-)

-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel