all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC installer] d/rules: allow for local testing suffixes to debian versions
Date: Thu,  6 Nov 2025 13:54:25 +0100	[thread overview]
Message-ID: <20251106125658.3362672-1-s.ivanov@proxmox.com> (raw)

When testing the installer in a ISO environment it can be quite
helpful to change the version of the debian-package to a temporary
higher version (which still orders below the next released version).

e.g. I now wanted to build a installer-package for some tests with
debian version 9.0.10~localtest1, but the build failed at
dh_auto_configure due to the mismatch.

While disabling/removing the check in those cases is not too much
effort either it might help others as well in not running into this.

I've only allowed for `~` and `+` as strippable suffix, as `-` would
at least cause lintian to complain about a strange version for a
native package.

Background on debian package versions:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version

This a change to
9528321 ("d/rules: add safe-guard to keep cargo and debian version in sync")

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
sending as RFC, as I'm not at all convinced that the patch is a help to more
people apart from myself. If we take it in I'll try to provide patches for
the other project as well (the commit introducing the change mentioned
pve-lxc-syscalld)

 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 8c9c6ed..07b8056 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,7 +12,7 @@ export BUILD_MODE=release
 	dh $@
 
 override_dh_auto_configure:
-	@perl -ne 'if (/^version\s*=\s*"(\d+(?:\.\d+)+)"/) { my $$v_cargo = $$1; my $$v_deb = "$(DEB_VERSION_UPSTREAM)"; \
+	@perl -ne 'if (/^version\s*=\s*"(\d+(?:\.\d+)+)"/) { my $$v_cargo = $$1; my $$v_deb = "$(DEB_VERSION_UPSTREAM)"; $$v_deb =~ s/[~+].*//; \
 	    die "ERROR: d/changelog <-> Cargo.toml version mismatch: $$v_cargo != $$v_deb\n" if $$v_cargo ne $$v_deb; exit(0); }' Cargo.toml
 	dh_auto_configure
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-11-06 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 12:54 Stoiko Ivanov [this message]
2025-11-06 18:43 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106125658.3362672-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal