From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default
Date: Tue, 4 Nov 2025 08:34:02 +0100 [thread overview]
Message-ID: <20251104073403.14933-1-h.laimer@proxmox.com> (raw)
There is no reason to still default to only listing pulling jobs.
Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/api2/admin/sync.rs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs
index 6722ebea..c21a6909 100644
--- a/src/api2/admin/sync.rs
+++ b/src/api2/admin/sync.rs
@@ -23,18 +23,17 @@ use crate::{
server::sync::do_sync_job,
};
-// FIXME: 4.x make 'all' the default
#[api()]
#[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
/// The direction of the listed sync jobs: push, pull or all.
pub enum ListSyncDirection {
/// All directions
+ #[default]
All,
/// Sync direction push
Push,
/// Sync direction pull
- #[default]
Pull,
}
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-11-04 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 7:34 Hannes Laimer [this message]
2025-11-04 8:58 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104073403.14933-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.