From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v2 1/1] status: rrddata: use fixed pve-vm-9.0 path
Date: Mon, 3 Nov 2025 23:00:20 +0100 [thread overview]
Message-ID: <20251103220024.2488005-6-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20251103220024.2488005-1-a.lauterer@proxmox.com>
Because we now always create it, should it not exists and old data is
used from the old files.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
---
Notes:
changes since
v1:
* rebase on current master after a small change due to tidying
#
src/PVE/API2/Qemu.pm | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 71bedc1e..c2bac61b 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -1657,11 +1657,9 @@ __PACKAGE__->register_method({
code => sub {
my ($param) = @_;
- my $path = "pve-vm-9.0/$param->{vmid}";
- $path = "pve2-vm/$param->{vmid}" if !-e "/var/lib/rrdcached/db/${path}";
- return PVE::RRD::create_rrd_graph($path, $param->{timeframe}, $param->{ds},
- $param->{cf});
-
+ return PVE::RRD::create_rrd_graph(
+ "pve-vm-9.0/$param->{vmid}", $param->{timeframe}, $param->{ds}, $param->{cf},
+ );
},
});
@@ -1702,9 +1700,9 @@ __PACKAGE__->register_method({
code => sub {
my ($param) = @_;
- my $path = "pve-vm-9.0/$param->{vmid}";
- $path = "pve2-vm/$param->{vmid}" if !-e "/var/lib/rrdcached/db/${path}";
- return PVE::RRD::create_rrd_data($path, $param->{timeframe}, $param->{cf});
+ return PVE::RRD::create_rrd_data(
+ "pve-vm-9.0/$param->{vmid}", $param->{timeframe}, $param->{cf},
+ );
},
});
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-03 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 22:00 [pve-devel] [PATCH cluster/container/manager/qemu-server/storage v2 0/7] combine and simplify RRD handling Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 1/3] rrd: fix rrd time frames Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 2/3] RRD: fetch data from old rrd file if present and needed Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 3/3] pmxcfs: status.c: always use 9.0 rrd files Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH manager v2 1/1] status: rrddata: use fixed pve-node-9.0 path Aaron Lauterer
2025-11-03 22:00 ` Aaron Lauterer [this message]
2025-11-03 22:00 ` [pve-devel] [PATCH container v2 1/1] status: rrddata: use fixed pve-vm-9.0 path Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH storage v2 1/1] status: rrddata: use fixed pve-storage-9.0 path Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103220024.2488005-6-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.