From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster v2 1/3] rrd: fix rrd time frames
Date: Mon, 3 Nov 2025 23:00:16 +0100 [thread overview]
Message-ID: <20251103220024.2488005-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20251103220024.2488005-1-a.lauterer@proxmox.com>
month with the new rrd files provides a resoltion of 30 minutes
year had a typo 1140 which should be 1440
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
---
src/PVE/RRD.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm
index 8fe1927..932191d 100644
--- a/src/PVE/RRD.pm
+++ b/src/PVE/RRD.pm
@@ -28,8 +28,8 @@ sub create_rrd_data {
hour => [60, 60], # 1 min resolution
day => [60, 1440], # 1 min resolution, full day
week => [60 * 30, 336], # 30 min resolution, 7 days
- month => [3600 * 6, 121], # 6 hour resolution, 30 days, need one more count. Otherwise RRD gets wrong $step
- year => [3600 * 6, 1140], # 6 hour resolution, 360 days
+ month => [60 * 30, 1440], # 30 min resolution 30 days
+ year => [3600 * 6, 1440], # 6 hour resolution, 360 days
decade => [86400 * 7, 570], # 1 week resolution, 10 years
};
@@ -115,8 +115,8 @@ sub create_rrd_graph {
hour => [60, 60], # 1 min resolution
day => [60, 1440], # 1 min resolution, full day
week => [60 * 30, 336], # 30 min resolution, 7 days
- month => [3600 * 6, 121], # 6 hour resolution, 30 days, need one more count. Otherwise RRD gets wrong $step
- year => [3600 * 6, 1140], # 6 hour resolution, 360 days
+ month => [60 * 30, 1440], # 30 min resolution 30 days
+ year => [3600 * 6, 1440], # 6 hour resolution, 360 days
decade => [86400 * 7, 570], # 1 week resolution, 10 years
};
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-03 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 22:00 [pve-devel] [PATCH cluster/container/manager/qemu-server/storage v2 0/7] combine and simplify RRD handling Aaron Lauterer
2025-11-03 22:00 ` Aaron Lauterer [this message]
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 2/3] RRD: fetch data from old rrd file if present and needed Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 3/3] pmxcfs: status.c: always use 9.0 rrd files Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH manager v2 1/1] status: rrddata: use fixed pve-node-9.0 path Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH qemu-server v2 1/1] status: rrddata: use fixed pve-vm-9.0 path Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH container " Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH storage v2 1/1] status: rrddata: use fixed pve-storage-9.0 path Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103220024.2488005-2-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.