From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 1/4] lvm plugin: snapshot delete: propagate previously captured error
Date: Mon, 3 Nov 2025 17:23:12 +0100 [thread overview]
Message-ID: <20251103162330.112603-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20251103162330.112603-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/Storage/LVMPlugin.pm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 275e84a..24f2534 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1190,9 +1190,7 @@ sub volume_snapshot_delete {
}
#delete the snapshot
my $cleanup_worker = eval { free_snap_image($class, $storeid, $scfg, $volname, $snap); };
- if ($@) {
- die "error deleting old snapshot volume $snapvolname\n";
- }
+ die "error deleting old snapshot volume $snapvolname: $@\n" if $@;
fork_cleanup_worker($cleanup_worker);
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-03 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 16:23 [pve-devel] [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes Fiona Ebner
2025-11-03 16:23 ` Fiona Ebner [this message]
2025-11-03 16:23 ` [pve-devel] [PATCH storage 2/4] lvm plugin: fix error handling in volume_snapshot_rollback() Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 3/4] lvm plugin: volume import: lock allocation and removal sections Fiona Ebner
2025-11-03 16:23 ` [pve-devel] [PATCH storage 4/4] lvm plugin: snapshot-as-volume-chain: use locking for snapshot operations Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103162330.112603-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.