all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v3 00/21] prepare ui for customizable views
Date: Fri, 31 Oct 2025 13:43:43 +0100	[thread overview]
Message-ID: <20251031124822.2739685-1-d.csapak@proxmox.com> (raw)

This is the first step to have customizable views in the PDM ui.

A few open points:

* The `LoadResult` struct should probably live in either pwt or
  yew-comp. I did not move it to pwt yet, but I'll do that for the next
  version.

* Not super sure if this kind of structure is the one we desire.
  The View is (for now) only a single layout (Row) that provides
  the same behavior as the current layout. The whole logic is in the
  View and every bit we want to add has to be handled there.

Note that we'll have to move the types for the View/ViewLayout/etc. to
the pdm-api-types,  since we'll also want to use them on the
backend. I'll do that too in a v4.

changes from v2:
* rebase on master (includes now the pbs datastore & node panel)
* integrated @shannon's feedback (just holler if i forgot something)
* added an edit mode
* restructured the `view` so that we can have a component per layout
  type (currently only `RowView`)
* changed the type of the laod results to use SharedState, so we
  can copy the Rc around instead of the actual data.
* moved the subscription info loading to the view

changes from v1:
* rebased on master
* added new patch to fix dashboard layout after change to views (patch 7)

Dominik Csapak (21):
  ui: dashboard: refactor guest panel creation to its own module
  ui: dashboard: refactor creating the node panel into its own module
  ui: dashboard: node panel: make remote type optional
  ui: dashboard: refactor remote panel creation into its own module
  ui: dashboard: remote panel: make wizard menu optional
  ui: dashboard: refactor sdn panel creation into its own module
  ui: dashboard: refactor task summary panel creation to its own module
  ui: dashboard: task summary: disable virtual scrolling
  ui: dashboard: refactor subscription panel creation to its own module
  ui: dashboard: refactor top entities panel creation to its own module
  ui: dashboard: refactor DashboardConfig editing/constants to their
    module
  ui: dashboard: factor out task parameter calculation
  ui: dashboard: pbs datastores panel: refactor creation into own module
  ui: dashboard: remove unused remote list
  ui: dashboard: status row: make loading less jarring
  ui: introduce `LoadResult` helper type
  ui: dashboard: implement 'View'
  ui: dashboard: use 'View' instead of the Dashboard
  ui: dashboard: subscription info: move subscription loading to view
  ui: dashboard: use SharedState for create_*_panel
  ui: dashboard: enable editing view

 ui/Cargo.toml                            |   2 +-
 ui/css/pdm.scss                          |   4 +
 ui/src/dashboard/guest_panel.rs          | 100 +++-
 ui/src/dashboard/mod.rs                  | 684 +----------------------
 ui/src/dashboard/node_status_panel.rs    | 100 +++-
 ui/src/dashboard/pbs_datastores_panel.rs |  38 +-
 ui/src/dashboard/refresh_config_edit.rs  | 107 ++++
 ui/src/dashboard/remote_panel.rs         |  59 +-
 ui/src/dashboard/sdn_zone_panel.rs       |  21 +-
 ui/src/dashboard/status_row.rs           |  40 +-
 ui/src/dashboard/subscription_info.rs    | 116 ++--
 ui/src/dashboard/tasks.rs                |  44 ++
 ui/src/dashboard/top_entities.rs         |  55 +-
 ui/src/dashboard/types.rs                |  79 +++
 ui/src/dashboard/view.rs                 | 539 ++++++++++++++++++
 ui/src/dashboard/view/row_element.rs     | 130 +++++
 ui/src/dashboard/view/row_view.rs        | 497 ++++++++++++++++
 ui/src/lib.rs                            |   5 +-
 ui/src/load_result.rs                    |  42 ++
 ui/src/main_menu.rs                      |   5 +-
 ui/src/pbs/remote.rs                     |  30 +-
 ui/src/pve/lxc/overview.rs               |  28 +-
 ui/src/pve/mod.rs                        |   4 +-
 ui/src/pve/node/overview.rs              |  29 +-
 ui/src/pve/qemu/overview.rs              |  28 +-
 ui/src/pve/storage.rs                    |  29 +-
 26 files changed, 1913 insertions(+), 902 deletions(-)
 create mode 100644 ui/src/dashboard/refresh_config_edit.rs
 create mode 100644 ui/src/dashboard/types.rs
 create mode 100644 ui/src/dashboard/view.rs
 create mode 100644 ui/src/dashboard/view/row_element.rs
 create mode 100644 ui/src/dashboard/view/row_view.rs
 create mode 100644 ui/src/load_result.rs

-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-10-31 12:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 12:43 Dominik Csapak [this message]
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 01/21] ui: dashboard: refactor guest panel creation to its own module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 02/21] ui: dashboard: refactor creating the node panel into " Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 03/21] ui: dashboard: node panel: make remote type optional Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 04/21] ui: dashboard: refactor remote panel creation into its own module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 05/21] ui: dashboard: remote panel: make wizard menu optional Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 06/21] ui: dashboard: refactor sdn panel creation into its own module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 07/21] ui: dashboard: refactor task summary panel creation to " Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 08/21] ui: dashboard: task summary: disable virtual scrolling Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 09/21] ui: dashboard: refactor subscription panel creation to its own module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 10/21] ui: dashboard: refactor top entities " Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 11/21] ui: dashboard: refactor DashboardConfig editing/constants to their module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 12/21] ui: dashboard: factor out task parameter calculation Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 13/21] ui: dashboard: pbs datastores panel: refactor creation into own module Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 14/21] ui: dashboard: remove unused remote list Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 15/21] ui: dashboard: status row: make loading less jarring Dominik Csapak
2025-10-31 12:43 ` [pdm-devel] [PATCH datacenter-manager v3 16/21] ui: introduce `LoadResult` helper type Dominik Csapak
2025-10-31 12:44 ` [pdm-devel] [PATCH datacenter-manager v3 17/21] ui: dashboard: implement 'View' Dominik Csapak
2025-10-31 12:44 ` [pdm-devel] [PATCH datacenter-manager v3 18/21] ui: dashboard: use 'View' instead of the Dashboard Dominik Csapak
2025-10-31 12:44 ` [pdm-devel] [PATCH datacenter-manager v3 19/21] ui: dashboard: subscription info: move subscription loading to view Dominik Csapak
2025-10-31 12:44 ` [pdm-devel] [PATCH datacenter-manager v3 20/21] ui: dashboard: use SharedState for create_*_panel Dominik Csapak
2025-10-31 12:44 ` [pdm-devel] [PATCH datacenter-manager v3 21/21] ui: dashboard: enable editing view Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251031124822.2739685-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal