From: Robert Obkircher <r.obkircher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 pve-container 0/2] warn that nesting may be required
Date: Tue, 28 Oct 2025 11:35:46 +0100 [thread overview]
Message-ID: <20251028103642.12891-1-r.obkircher@proxmox.com> (raw)
This patch adds a task-log warning on CT start if systemd is detected.
Changes since v2:
- read $@ before new eval to preserve error
- remove trailing whitespace
Changes since v1:
- increase minimum systemd version to something more reasonable
- introduce helper callback to log warinings
- replace RESTEnvironmnet::log_warn in setup plugins
- syntactic changes:
- renamed get_may_require_nesting_warning to check_systemd_nesting
- use trailing if for return statements
- call code from pre_start_hook as suggested
Robert Obkircher (2):
fix 6897: warn that nesting may be required for systemd
Propagate prestart-hook warnings to task-log.
src/PVE/LXC.pm | 6 ++++--
src/PVE/LXC/Setup.pm | 14 +++++++++++---
src/PVE/LXC/Setup/Base.pm | 21 ++++++++++++++++++++-
src/PVE/LXC/Setup/Debian.pm | 5 ++---
src/PVE/LXC/Setup/Plugin.pm | 2 +-
src/PVE/LXC/Setup/Ubuntu.pm | 5 ++---
src/lxc-pve-prestart-hook | 24 +++++++++++-------------
7 files changed, 51 insertions(+), 26 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-28 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 10:35 Robert Obkircher [this message]
2025-10-28 10:35 ` [pve-devel] [PATCH v3 pve-container 1/2] fix 6897: warn that nesting may be required for systemd Robert Obkircher
2025-10-28 10:35 ` [pve-devel] [PATCH v3 pve-container 2/2] Propagate prestart-hook warnings to task-log Robert Obkircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028103642.12891-1-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.