all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v3 08/19] ui: dashboard: reimplement node status panel as dedicated component
Date: Tue, 21 Oct 2025 13:11:18 +0200	[thread overview]
Message-ID: <20251021111129.294349-9-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251021111129.294349-1-c.ebner@proxmox.com>

Reimplement the current node status panel as a dedicated component
for better encapsulation and input data handling, analogous to how
guest status or SDN status panels are handled.

Instead of passing in the whole status, only pass the state required
for the component to be rendered.

Already take into account that this will be used to render the PBS
node status as well.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Changes since version 2:
- no changes

 ui/src/dashboard/node_status_panel.rs | 144 ++++++++++++++++++++++++++
 1 file changed, 144 insertions(+)
 create mode 100644 ui/src/dashboard/node_status_panel.rs

diff --git a/ui/src/dashboard/node_status_panel.rs b/ui/src/dashboard/node_status_panel.rs
new file mode 100644
index 0000000..e9e8c6b
--- /dev/null
+++ b/ui/src/dashboard/node_status_panel.rs
@@ -0,0 +1,144 @@
+use std::rc::Rc;
+
+use pdm_api_types::remotes::RemoteType;
+use pdm_api_types::resource::NodeStatusCount;
+use pdm_search::{Search, SearchTerm};
+use proxmox_yew_comp::Status;
+use pwt::{
+    css::{AlignItems, FlexFit, JustifyContent},
+    prelude::*,
+    widget::{Column, Fa},
+};
+use yew::{
+    virtual_dom::{VComp, VNode},
+    Properties,
+};
+
+use crate::search_provider::get_search_provider;
+
+use super::loading_column;
+
+#[derive(PartialEq, Clone, Properties)]
+pub struct NodeStatusPanel {
+    remote_type: RemoteType,
+    status: Option<NodeStatusCount>,
+    failed_remotes: usize,
+}
+
+impl NodeStatusPanel {
+    pub fn new(
+        remote_type: RemoteType,
+        status: Option<NodeStatusCount>,
+        failed_remotes: usize,
+    ) -> Self {
+        yew::props!(Self {
+            remote_type,
+            status,
+            failed_remotes,
+        })
+    }
+}
+
+impl From<NodeStatusPanel> for VNode {
+    fn from(value: NodeStatusPanel) -> Self {
+        let comp = VComp::new::<NodeStatusPanelComponent>(Rc::new(value), None);
+        VNode::from(comp)
+    }
+}
+
+pub struct NodeStatusPanelComponent {}
+
+impl yew::Component for NodeStatusPanelComponent {
+    type Message = Search;
+    type Properties = NodeStatusPanel;
+
+    fn create(_ctx: &yew::Context<Self>) -> Self {
+        Self {}
+    }
+
+    fn update(&mut self, ctx: &Context<Self>, msg: Self::Message) -> bool {
+        if let Some(provider) = get_search_provider(ctx) {
+            provider.search(msg);
+        }
+        false
+    }
+
+    fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
+        let props = ctx.props();
+
+        let (icon, status_msg, search_terms) = match &props.status {
+            Some(status) => map_status(status, props.remote_type, props.failed_remotes),
+            None => return loading_column().into(),
+        };
+
+        let column = Column::new()
+            .padding(4)
+            .class("pwt-pointer")
+            .class(FlexFit)
+            .class(AlignItems::Center)
+            .class(JustifyContent::Center)
+            .gap(2)
+            .onclick(ctx.link().callback({
+                let search_terms = search_terms.clone();
+                move |_| Search::with_terms(search_terms.clone())
+            }))
+            .onkeydown(ctx.link().batch_callback({
+                let search_terms = search_terms.clone();
+                move |event: KeyboardEvent| match event.key().as_str() {
+                    "Enter" | " " => Some(Search::with_terms(search_terms.clone())),
+                    _ => None,
+                }
+            }))
+            .with_child(icon.large_4x())
+            .with_child(status_msg);
+        column.into()
+    }
+}
+
+fn map_status(
+    status: &NodeStatusCount,
+    remote_type: RemoteType,
+    failed_remotes: usize,
+) -> (Fa, String, Vec<SearchTerm>) {
+    let mut search_terms = vec![
+        SearchTerm::new("node").category(Some("type")),
+        SearchTerm::new(remote_type.to_string()).category(Some("remote-type")),
+    ];
+    let (icon, status_msg) = match status {
+        NodeStatusCount {
+            online,
+            offline,
+            unknown,
+        } if *offline > 0 => {
+            search_terms.push(SearchTerm::new("offline").category(Some("status")));
+            (
+                Status::Error.into(),
+                tr!(
+                    "{0} of {1} nodes are offline",
+                    offline,
+                    online + offline + unknown,
+                ),
+            )
+        }
+        NodeStatusCount { unknown, .. } if *unknown > 0 => {
+            search_terms.push(SearchTerm::new("unknown").category(Some("status")));
+            (
+                Status::Warning.into(),
+                tr!("{0} nodes have an unknown status", unknown),
+            )
+        }
+        NodeStatusCount { online, .. } if failed_remotes > 0 => match remote_type {
+            RemoteType::Pve => (
+                Status::Unknown.into(),
+                tr!("{0} of an unknown number of nodes online", online),
+            ),
+            RemoteType::Pbs => (
+                Status::Error.into(),
+                tr!("{0} remotes failed", failed_remotes),
+            ),
+        },
+        NodeStatusCount { online, .. } => (Status::Success.into(), tr!("{0} nodes online", online)),
+    };
+
+    (icon, status_msg, search_terms)
+}
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-10-21 11:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 11:11 [pdm-devel] [PATCH datacenter-manager v3 00/19] add remote type based search and PBS node status panel to dashboard Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 01/19] server: fix small formatting issue via `cargo fmt` Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 02/19] server: api: pass remote as reference to fetching helpers Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 03/19] server: api: refactor filter logic for resource post gathering Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 04/19] api: resources: new transient type for remote resource gathering Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 05/19] server: api: add remote-type search category for resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 06/19] pdm-api-types: extend resource status by list of failed remotes Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 07/19] server: api: collect failed remotes list while getting status Christian Ebner
2025-10-21 11:11 ` Christian Ebner [this message]
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 09/19] ui: dashboard: use new node status component Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 10/19] ui: dashboard: extend node panel creation by remote type Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 11/19] ui: dashboard: expose PBS nodes status panel Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 12/19] pdm-api-types: introduce PBS datastore specific counters Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 13/19] pdm-api-types/resources: extend datastore resources by config properties Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 14/19] server: resources: extend the PBS " Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 15/19] server: resources: extend datastore status counters by multiple states Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 16/19] pdm-api-types: extend status matching for PBS datastore resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 17/19] pdm-api-types: extend resources by properties string generator method Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 18/19] server: resources: add property matching for resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 19/19] ui: dashboard: add panel for PBS datastore statistics Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251021111129.294349-9-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal