all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v3 02/19] server: api: pass remote as reference to fetching helpers
Date: Tue, 21 Oct 2025 13:11:12 +0200	[thread overview]
Message-ID: <20251021111129.294349-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251021111129.294349-1-c.ebner@proxmox.com>

None of the helpers requires ownership of the remote, therefore pass
it as shared reference.

This is in preparation for passing the remote also to the search term
filtering to allow matching the remote type.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Changes since version 2:
- no changes

 server/src/api/resources.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index d629c65..21143a8 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -255,7 +255,7 @@ pub(crate) async fn get_resources_impl(
         }
         let filter = filters.clone();
         let handle = tokio::spawn(async move {
-            let (mut resources, error) = match get_resources_for_remote(remote, max_age).await {
+            let (mut resources, error) = match get_resources_for_remote(&remote, max_age).await {
                 Ok(resources) => (resources, None),
                 Err(error) => {
                     tracing::debug!("failed to get resources from remote - {error:?}");
@@ -700,7 +700,7 @@ static CACHE: LazyLock<RwLock<HashMap<String, CachedResources>>> =
 ///
 /// If recent enough cached data is available, it is returned
 /// instead of calling out to the remote.
-async fn get_resources_for_remote(remote: Remote, max_age: u64) -> Result<Vec<Resource>, Error> {
+async fn get_resources_for_remote(remote: &Remote, max_age: u64) -> Result<Vec<Resource>, Error> {
     let remote_name = remote.id.to_owned();
     if let Some(cached_resource) = get_cached_resources(&remote_name, max_age) {
         Ok(cached_resource.resources)
@@ -756,7 +756,7 @@ fn update_cached_resources(remote: &str, resources: &[Resource], now: i64) {
 }
 
 /// Fetch remote resources and map to pdm-native data types.
-async fn fetch_remote_resource(remote: Remote) -> Result<Vec<Resource>, Error> {
+async fn fetch_remote_resource(remote: &Remote) -> Result<Vec<Resource>, Error> {
     let mut resources = Vec::new();
     let remote_name = remote.id.to_owned();
 
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-10-21 11:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 11:11 [pdm-devel] [PATCH datacenter-manager v3 00/19] add remote type based search and PBS node status panel to dashboard Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 01/19] server: fix small formatting issue via `cargo fmt` Christian Ebner
2025-10-21 11:11 ` Christian Ebner [this message]
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 03/19] server: api: refactor filter logic for resource post gathering Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 04/19] api: resources: new transient type for remote resource gathering Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 05/19] server: api: add remote-type search category for resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 06/19] pdm-api-types: extend resource status by list of failed remotes Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 07/19] server: api: collect failed remotes list while getting status Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 08/19] ui: dashboard: reimplement node status panel as dedicated component Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 09/19] ui: dashboard: use new node status component Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 10/19] ui: dashboard: extend node panel creation by remote type Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 11/19] ui: dashboard: expose PBS nodes status panel Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 12/19] pdm-api-types: introduce PBS datastore specific counters Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 13/19] pdm-api-types/resources: extend datastore resources by config properties Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 14/19] server: resources: extend the PBS " Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 15/19] server: resources: extend datastore status counters by multiple states Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 16/19] pdm-api-types: extend status matching for PBS datastore resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 17/19] pdm-api-types: extend resources by properties string generator method Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 18/19] server: resources: add property matching for resources Christian Ebner
2025-10-21 11:11 ` [pdm-devel] [PATCH datacenter-manager v3 19/19] ui: dashboard: add panel for PBS datastore statistics Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251021111129.294349-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal