From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-yew-quarantine-gui/proxmox/yew-comp 0/3] fix ldap login for pmg mobile quarantine
Date: Mon, 20 Oct 2025 17:03:50 +0200 [thread overview]
Message-ID: <20251020170350.771358ce@rosa.proxmox.com> (raw)
In-Reply-To: <20251015142310.3633830-1-d.csapak@proxmox.com>
Thanks for the quick patch!
I gave it a spin - and after our talk off-list I agree that the fix as
is makes sense:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
On Wed, 15 Oct 2025 16:22:57 +0200
Dominik Csapak <d.csapak@proxmox.com> wrote:
> Fixes the login for ldap users of the quarantine by disabling the
> realm selector on the login page, and by fixing the userid checking
> in proxmox-login
>
> note that the pmg-yew-quarantine-gui patch depends on both a bumped
> proxmox-login and yew-comp for this to work correctly
>
> proxmox:
>
> Dominik Csapak (1):
> login: fix userid check for '@quarantine' user tickets
>
> proxmox-login/src/lib.rs | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>
> proxmox-yew-comp:
>
> Dominik Csapak (1):
> login panel: make realm selector optional
>
> src/login_panel.rs | 52 +++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 42 insertions(+), 10 deletions(-)
>
>
> pmg-yew-quarantine-gui:
>
> Dominik Csapak (1):
> login page: disable realm selection
>
> src/page_login.rs | 1 +
> 1 file changed, 1 insertion(+)
>
>
> Summary over all repositories:
> 3 files changed, 48 insertions(+), 17 deletions(-)
>
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-10-20 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 14:22 Dominik Csapak
2025-10-15 14:22 ` [pmg-devel] [PATCH proxmox 1/1] login: fix userid check for '@quarantine' user tickets Dominik Csapak
2025-10-21 18:33 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-15 14:22 ` [pmg-devel] [PATCH yew-comp 1/1] login panel: make realm selector optional Dominik Csapak
2025-10-22 17:03 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-23 6:54 ` Dominik Csapak
2025-10-15 14:23 ` [pmg-devel] [PATCH pmg-yew-quarantine-gui 1/1] login page: disable realm selection Dominik Csapak
2025-10-22 17:35 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-20 15:03 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020170350.771358ce@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.