all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager/yew-comp/yew-widget-toolkit v3 0/7] add better token support for pdm
Date: Fri, 17 Oct 2025 14:46:40 +0200	[thread overview]
Message-ID: <20251017124646.294343-2-s.sterz@proxmox.com> (raw)

this series aims to add a ui to the pre-existing token support in pdm.
it also aims to get it more in-line with what other proxmox products
provide in terms of functionality.

the first commit adds the ability to mark fields as read-only via the
`readonly` html attribute in preparation for the next parts of the
series.

the next two commits improve the token panel in proxmox-yew-comp by
using the Clipboard API when copying values. the layout and
functionality of the dialog displaying the token secret is also
improved. the fourth commit tries to split up the utils module in
yew-comp somewhat by using re-exports and a dedicated clipboard sub
module for the clipboard helpers.

the final three patches integrate the token panel in pdm's ui. they also
refactor the api endpoints related token handling to use the new
endpoints from proxmxo-access-control and make sure the user delete
endpoint cleans up acls and tokens too.

Changelog
---------

changes since v2:
- make the token secret manually selectable again (thanks @ Lukas
  Wagner)
- add a doc comment for the new clipboard helper (thanks @ Lukas Wagner)
- move clipboard helpers to their own sub-module (thanks @ Lukas Wagner)

changes since v1:
- the patches for proxmox-access-control got applied (thanks @ Thomas
  Lamprecht)
- use `.gap(2)` instead of `.margin_start(2)` (thanks @ Dominik Csapak)
- use `ColorScheme::WarningContainer` and `pwt-default-color` instead of
  manually setting background and color classes (thanks @ Dominik
  Csapak)
- rebased on current master branches

changes since rfc:
- the commits implementing the basic token panel have already been
  applied by Thomas Lamprecht, thanks!
- moved adding `use` and `mod` statements for the token module to the
  right commit in the series (thanks @ Dominik Csapak)
- generate token secrets in the `token_shadow` module instead of in the
  token endpoints themselves (thanks @ Fabian Grünbichler)
- use a schema for the `regenerate` parameter of the update token
  endpoint (thanks @ Fabian Grünbichler)
- allow deleting comments via a `delete` property (thanks @ Fabian
  Grünbichler)
- make the token delete endpoint clean up token acls (thanks @ Fabian
  Grünbichler)
- improve copy to clipboard functionality to use the new Clipboard API
- improve the layout of the token secret dialog (thanks @ Thomas
  Lamprecht)

proxmox-yew-widget-toolkit:

Shannon Sterz (1):
  props: add readonly to field_std_props

 src/props/field_builder.rs   | 11 +++++++++++
 src/props/field_std_props.rs | 11 +++++++++++
 2 files changed, 22 insertions(+)


proxmox-yew-comp:

Shannon Sterz (3):
  utils/tfa add recover/token panel: add copy_text_to_clipboard function
  token panel: improve token secret dialog layout and hide password
  utils: split out clipboard helpers into their own modules

 Cargo.toml                     |   2 +
 src/tfa/tfa_add_recovery.rs    |  17 ++---
 src/token_panel.rs             | 116 ++++++++++++++++-----------------
 src/utils/clipboard.rs         |  46 +++++++++++++
 src/{utils.rs => utils/mod.rs} |  24 ++-----
 5 files changed, 116 insertions(+), 89 deletions(-)
 create mode 100644 src/utils/clipboard.rs
 rename src/{utils.rs => utils/mod.rs} (96%)


proxmox-datacenter-manager:

Shannon Sterz (3):
  ui: add a token panel and a token acl edit menu in the permissions
    panel
  server: access: use token endpoints from proxmox-access-control
  server: clean up acl tree entries and api tokens when deleting users

 server/src/api/access/users.rs | 390 ++++++---------------------------
 ui/src/configuration/mod.rs    |  33 ++-
 2 files changed, 96 insertions(+), 327 deletions(-)


Summary over all repositories:
  9 files changed, 234 insertions(+), 416 deletions(-)

--
Generated by git-murpp 0.8.1


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

             reply	other threads:[~2025-10-17 12:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 12:46 Shannon Sterz [this message]
2025-10-17 12:46 ` [pdm-devel] [PATCH yew-widget-toolkit v3 1/1] props: add readonly to field_std_props Shannon Sterz
2025-10-21 18:52   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH yew-comp v3 1/3] utils/tfa add recover/token panel: add copy_text_to_clipboard function Shannon Sterz
2025-10-22 17:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH yew-comp v3 2/3] token panel: improve token secret dialog layout and hide password Shannon Sterz
2025-10-22 17:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH yew-comp v3 3/3] utils: split out clipboard helpers into their own modules Shannon Sterz
2025-10-17 12:51   ` Shannon Sterz
2025-10-22 17:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH datacenter-manager v3 1/3] ui: add a token panel and a token acl edit menu in the permissions panel Shannon Sterz
2025-10-17 12:52   ` Shannon Sterz
2025-10-22 17:22   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH datacenter-manager v3 2/3] server: access: use token endpoints from proxmox-access-control Shannon Sterz
2025-10-17 12:52   ` Shannon Sterz
2025-10-22 17:22   ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-17 12:46 ` [pdm-devel] [PATCH datacenter-manager v3 3/3] server: clean up acl tree entries and api tokens when deleting users Shannon Sterz
2025-10-17 12:52   ` Shannon Sterz
2025-10-22 17:22   ` [pdm-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251017124646.294343-2-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal