From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v3 3/7] fix #1964: follow guest-fsfreeze setting on check freeze needed
Date: Tue, 14 Oct 2025 14:27:10 +0200 [thread overview]
Message-ID: <20251014122718.374205-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20251014122718.374205-1-m.sandoval@proxmox.com>
This method is used by replications and snapshots without RAM.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/PVE/QemuConfig.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index bb469197..412c76ae 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -298,7 +298,8 @@ sub __snapshot_check_freeze_needed {
$running,
$running
&& PVE::QemuServer::Agent::get_qga_key($config, 'enabled')
- && PVE::QemuServer::Agent::qga_check_running($vmid),
+ && PVE::QemuServer::Agent::qga_check_running($vmid)
+ && PVE::QemuServer::Agent::get_qga_key($config, 'guest-fsfreeze') // 1,
);
} else {
return ($running, 0);
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-14 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 12:27 [pve-devel] [PATCH container/guest-common/qemu-server v3 0/9] fix #1964: add setting to always disable freezing a guest Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 1/7] add a guest-fsfreeze qga setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 2/7] block job: mirror: follow guest-fsfreeze setting Maximiliano Sandoval
2025-10-14 12:27 ` Maximiliano Sandoval [this message]
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 4/7] log when issuing a guest-fsfreeze command Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 5/7] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 6/7] block job: log if fs-freeze is skipped due to config Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 7/7] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH container v3 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH guest-common v3 1/1] replication: remove logging when freezing/thawing Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014122718.374205-4-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.