From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox] schema: drop leftover useless i64 check
Date: Tue, 14 Oct 2025 12:24:12 +0200 [thread overview]
Message-ID: <20251014102444.844799-1-f.gruenbichler@proxmox.com> (raw)
since 7ac306e268e2840d258af41ce8cec890fc372351 IntegerSchema is no longer
isize, but i64, so this check is pointless.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
clippy complained about the useless conversion here, sending on-list in case I
missed something..
proxmox-schema/src/de/mod.rs | 3 ---
1 file changed, 3 deletions(-)
diff --git a/proxmox-schema/src/de/mod.rs b/proxmox-schema/src/de/mod.rs
index 1f14503e..ea2115c5 100644
--- a/proxmox-schema/src/de/mod.rs
+++ b/proxmox-schema/src/de/mod.rs
@@ -180,9 +180,6 @@ impl<'de> de::Deserializer<'de> for SchemaDeserializer<'de, '_> {
schema.check_constraints(value).map_err(Error::invalid)?;
- let value: i64 = i64::try_from(value)
- .map_err(|_| Error::invalid("isize did not fit into i64"))?;
-
if let Ok(value) = u64::try_from(value) {
visitor.visit_u64(value)
} else {
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
reply other threads:[~2025-10-14 10:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014102444.844799-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.