all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 2/7] pdm-api-types: extend resource status by list of failed remotes
Date: Mon, 13 Oct 2025 10:56:18 +0200	[thread overview]
Message-ID: <20251013085623.211136-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251013085623.211136-1-c.ebner@proxmox.com>

Currently only the count of failed remotes is returned via the
status. Include the list of failed remotes including the name,
remote type and error message.

This will be used to extend the dashboard panel.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 lib/pdm-api-types/src/remotes.rs  |  3 ++-
 lib/pdm-api-types/src/resource.rs | 28 ++++++++++++++++++++++++++--
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/lib/pdm-api-types/src/remotes.rs b/lib/pdm-api-types/src/remotes.rs
index 6318943..dd6afa6 100644
--- a/lib/pdm-api-types/src/remotes.rs
+++ b/lib/pdm-api-types/src/remotes.rs
@@ -39,10 +39,11 @@ pub struct NodeUrl {
 
 #[api]
 /// The type of a remote entry.
-#[derive(Clone, Copy, Debug, Eq, PartialEq, Deserialize, Serialize, Ord, PartialOrd)]
+#[derive(Clone, Copy, Default, Debug, Eq, PartialEq, Deserialize, Serialize, Ord, PartialOrd)]
 #[serde(rename_all = "lowercase")]
 pub enum RemoteType {
     /// A Proxmox VE node.
+    #[default]
     Pve,
     /// A Proxmox Backup Server node.
     Pbs,
diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs
index b219250..400f2af 100644
--- a/lib/pdm-api-types/src/resource.rs
+++ b/lib/pdm-api-types/src/resource.rs
@@ -5,7 +5,7 @@ use serde::{Deserialize, Serialize};
 
 use proxmox_schema::{api, ApiStringFormat, ApiType, EnumEntry, OneOfSchema, Schema, StringSchema};
 
-use super::remotes::REMOTE_ID_SCHEMA;
+use super::remotes::{RemoteType, REMOTE_ID_SCHEMA};
 
 #[api(
     "id-property": "id",
@@ -550,7 +550,16 @@ pub struct SdnZoneCount {
     pub unknown: u64,
 }
 
-#[api]
+#[api(
+    properties: {
+        "failed_remotes_list": {
+            type: Array,
+            items: {
+                type: FailedRemote,
+            },
+        }
+    }
+)]
 #[derive(Default, Serialize, Deserialize, Clone, PartialEq)]
 /// Describes the status of seen resources
 pub struct ResourcesStatus {
@@ -572,6 +581,21 @@ pub struct ResourcesStatus {
     pub pbs_nodes: NodeStatusCount,
     /// Status of PBS Datastores
     pub pbs_datastores: StorageStatusCount,
+    /// List of the failed remotes including type and error
+    #[serde(default, skip_serializing_if = "Vec::is_empty")]
+    pub failed_remotes_list: Vec<FailedRemote>,
+}
+
+#[api]
+#[derive(Default, Serialize, Deserialize, Clone, PartialEq)]
+/// Error information for a failed remote
+pub struct FailedRemote {
+    /// Name of the failed remote
+    pub name: String,
+    /// Error that occurred when querying remote resources
+    pub error: String,
+    /// Type of the failed remote
+    pub remote_type: RemoteType,
 }
 
 #[api(
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-10-13  8:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13  8:56 [pdm-devel] [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 1/7] server: api: add remote-type search category for resources Christian Ebner
2025-10-14  8:35   ` Dominik Csapak
2025-10-14  9:01     ` Christian Ebner
2025-10-13  8:56 ` Christian Ebner [this message]
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 3/7] server: api: collect failed remotes list while getting status Christian Ebner
2025-10-14  8:37   ` Dominik Csapak
2025-10-14 12:41     ` Christian Ebner
2025-10-14 12:53       ` Dominik Csapak
2025-10-14 13:10         ` Christian Ebner
2025-10-14 13:17           ` Dominik Csapak
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 4/7] ui: dashboard: extend node panel creation by remote type Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on " Christian Ebner
2025-10-14  8:47   ` Dominik Csapak
2025-10-14  9:20     ` Christian Ebner
2025-10-14  9:24       ` Dominik Csapak
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 6/7] ui: dashboard: expose PBS nodes status panel Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 7/7] ui: dashboard: filter by remote type for PVE and PBS node " Christian Ebner
2025-10-17 14:13 ` [pdm-devel] superseded: [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251013085623.211136-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal