From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC storage 0/2] close #6669: plugin api: introduce on_update_hook_full() method
Date: Wed, 8 Oct 2025 17:11:30 +0200 [thread overview]
Message-ID: <20251008151140.127355-1-f.ebner@proxmox.com> (raw)
The original on_update_hook() method is limited, because only the
updated properties and values are passed in. Introduce a new
on_update_hook_full() method which also receives the current storage
configuration and the list of which properties are to be deleted. This
allows detecting and reacting to all changes and knowing how values
changed.
The first user of the new method is the LVM plugin to disallow
disabling 'snapshot-as-volume-chain' while a qcow2 image exists.
pve-storage:
Fiona Ebner (2):
close #6669: plugin api: introduce on_update_hook_full() method
lvm plugin: disallow disabling 'snapshot-as-volume-chain' while a
qcow2 image exists
ApiChangeLog | 13 +++++++++++++
src/PVE/API2/Storage/Config.pm | 18 +++++++++++++++---
src/PVE/Storage.pm | 4 ++--
src/PVE/Storage/LVMPlugin.pm | 19 +++++++++++++++++++
src/PVE/Storage/Plugin.pm | 33 +++++++++++++++++++++++++++++++++
5 files changed, 82 insertions(+), 5 deletions(-)
Summary over all repositories:
5 files changed, 82 insertions(+), 5 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-08 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 15:11 Fiona Ebner [this message]
2025-10-08 15:11 ` [pve-devel] [RFC storage 1/2] " Fiona Ebner
2025-10-08 15:11 ` [pve-devel] [RFC storage 2/2] lvm plugin: disallow disabling 'snapshot-as-volume-chain' while a qcow2 image exists Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008151140.127355-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.