From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] introduce streaming content api call
Date: Wed, 8 Oct 2025 15:43:29 +0200 [thread overview]
Message-ID: <20251008134344.3512958-1-d.csapak@proxmox.com> (raw)
This series introduces a new api call `content` on a datastore that
returns the whole content recursively, including namespaces, groups and
snapshots.
It's doing that using the proxmox-router::Stream, so a client can get
the separate records without having to wait for the api call to finish.
This is intended to improve ui responsiveness, since we can show things
even when it's still loading. This can be very useful for large
datastores.
This series contains some refactorings that were necessary, but also
includes one performance improvement for the `groups` api call (stumbled
upon it during testing)
changes from v1:
* remove content type filter from api call (we can decide later how/if
we want to filter that)
* remove use of exlicit async-stream (can be done via
proxmox-router::Stream)
* send errors to the stream too
* rename namespace helper
* restructure finding the first finished backup in
`backup_group_to_group_list_item`
* rename '*List' structs to have more concise names
* return the next level of namespaces in listing
proxmox:
Dominik Csapak (1):
pbs-api-types: add api types for streaming content api call
pbs-api-types/Cargo.toml | 1 +
pbs-api-types/src/datastore.rs | 89 ++++++++++++++++++++++++++++++++++
2 files changed, 90 insertions(+)
proxmox-backup:
Dominik Csapak (6):
backup: hierarchy: add new can_access_any_namespace_below helper
backup: hierarchy: reuse 'NS_PRIVS_OK' for namespace helper
api: admin: datastore: refactor BackupGroup to GroupListItem
conversion
api: admin: datastore: factor out 'get_group_owner'
api: admin: datastore: optimize `groups` api call
api: admin: datastore: implement streaming content api call
src/api2/admin/datastore.rs | 309 +++++++++++++++++++++++++++---------
src/backup/hierarchy.rs | 29 ++--
2 files changed, 251 insertions(+), 87 deletions(-)
Summary over all repositories:
4 files changed, 341 insertions(+), 87 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-10-08 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 13:43 Dominik Csapak [this message]
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox v2 1/1] pbs-api-types: add api types for " Dominik Csapak
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 1/6] backup: hierarchy: add new can_access_any_namespace_below helper Dominik Csapak
2025-10-08 20:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 2/6] backup: hierarchy: reuse 'NS_PRIVS_OK' for namespace helper Dominik Csapak
2025-10-08 20:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] api: admin: datastore: refactor BackupGroup to GroupListItem conversion Dominik Csapak
2025-10-08 20:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 4/6] api: admin: datastore: factor out 'get_group_owner' Dominik Csapak
2025-10-08 20:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] api: admin: datastore: optimize `groups` api call Dominik Csapak
2025-10-08 20:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-10-08 13:43 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] api: admin: datastore: implement streaming content " Dominik Csapak
2025-10-08 19:49 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008134344.3512958-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.