From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall 0/2] Fix generating rules with both ICMP type and code set
Date: Wed, 8 Oct 2025 15:14:52 +0200 [thread overview]
Message-ID: <20251008131457.178090-1-s.hanreich@proxmox.com> (raw)
If both type and code were set for rules with Protocol ICMP(v6) then
proxmox-firewall would only generate the statement matching on the code, but not
on the type.
proxmox-firewall:
Stefan Hanreich (2):
firewall: fix generating rules with both type and code set
firewall: regenerate snapshot for tests
proxmox-firewall/src/rule.rs | 32 ++++--
proxmox-firewall/tests/input/cluster.fw | 3 +
.../integration_tests__firewall.snap | 104 ++++++++++++++++++
3 files changed, 127 insertions(+), 12 deletions(-)
Summary over all repositories:
3 files changed, 127 insertions(+), 12 deletions(-)
--
Generated by git-murpp 0.8.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-08 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 13:14 Stefan Hanreich [this message]
2025-10-08 13:14 ` [pve-devel] [PATCH proxmox-firewall 1/2] firewall: fix generating rules with both " Stefan Hanreich
2025-10-08 13:14 ` [pve-devel] [PATCH proxmox-firewall 2/2] firewall: regenerate snapshot for tests Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008131457.178090-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.