From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES common/qemu-server v2 0/2] migration: conntrack: fix race adding dbus-vmstate object to QEMU
Date: Mon, 6 Oct 2025 13:55:51 +0200 [thread overview]
Message-ID: <20251006115648.804286-1-f.ebner@proxmox.com> (raw)
Changes in v2:
* Dropped already applied patches.
* Introduce sd_notify() helper.
* Different approach, make the service type=notify instead of waiting
in a sleep+check-loop until the object shows up via QMP 'qom-list'.
As reported in the community forum [0], it might happen that the
dbus-vmstate object is not added (quickly enough) to the target QEMU
instance, before the migration state is loaded. This would result in
a crash of the target instance.
[0]: https://forum.proxmox.com/threads/172588/
Dependency bump qemu-server -> pve-common needed.
pve-common:
Fiona Ebner (1):
systemd: add sd_notify() helper
src/PVE/Systemd.pm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
qemu-server:
Fiona Ebner (1):
migration: conntrack: avoid crash when dbus-vmstate object cannot be
added (quickly enough)
src/usr/dbus-vmstate | 3 +++
src/usr/pve-dbus-vmstate@.service | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
Summary over all repositories:
3 files changed, 25 insertions(+), 1 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-06 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 11:55 Fiona Ebner [this message]
2025-10-06 11:55 ` [pve-devel] [PATCH common v2 1/2] systemd: add sd_notify() helper Fiona Ebner
2025-10-06 13:14 ` Thomas Lamprecht
2025-10-07 10:26 ` Fiona Ebner
2025-10-06 11:55 ` [pve-devel] [PATCH qemu-server v2 2/2] migration: conntrack: avoid crash when dbus-vmstate object cannot be added (quickly enough) Fiona Ebner
2025-10-06 11:59 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006115648.804286-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.