From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall/ve-rs v2 0/3] Fix ICMP types in nftables
Date: Mon, 6 Oct 2025 12:19:28 +0200 [thread overview]
Message-ID: <20251006101933.90655-1-g.goller@proxmox.com> (raw)
Currently when setting ICMP types on the old firewall (iptables) then
switching to the new one (nftables) a few types will fail because they have
been renamed in nftables or do not exist in nftables. This affects both icmp
and icmpv6 where we now map options that do not exist in nftables to their
respective type/code combinations. This allows us to have exactly the same
behavior in nftables as we have in iptables.
Changelog:
v1, thanks Stefan and Thomas:
* no hard error when mapping not possible
* map all the types by falling back to custom type/code
* also map icmp types in addition to icmpv6
ve-rs:
Gabriel Goller (1):
fix: firewall: introduce iptables to nftables mapping for icmpv6-types
Wolfgang Bumiller (1):
fix: firewall: introduce iptables to nftables mapping for icmp-types
proxmox-ve-config/src/firewall/cluster.rs | 9 +-
proxmox-ve-config/src/firewall/types/rule.rs | 9 +-
.../src/firewall/types/rule_match.rs | 139 +++++++++++++++---
3 files changed, 129 insertions(+), 28 deletions(-)
proxmox-firewall:
Gabriel Goller (1):
tests: add icmpv6 type mapping test
proxmox-firewall/tests/input/host.fw | 1 +
.../integration_tests__firewall.snap | 63 +++++++++++++++++++
2 files changed, 64 insertions(+)
Summary over all repositories:
5 files changed, 193 insertions(+), 28 deletions(-)
--
Generated by git-murpp 0.8.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-06 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 10:19 Gabriel Goller [this message]
2025-10-06 10:19 ` [pve-devel] [PATCH ve-rs v2 1/2] fix: firewall: introduce iptables to nftables mapping for icmp-types Gabriel Goller
2025-10-07 11:43 ` Gabriel Goller
2025-10-06 10:19 ` [pve-devel] [PATCH ve-rs v2 2/2] fix: firewall: introduce iptables to nftables mapping for icmpv6-types Gabriel Goller
2025-10-06 10:19 ` [pve-devel] [PATCH proxmox-firewall v2 1/1] tests: add icmpv6 type mapping test Gabriel Goller
2025-10-08 13:17 ` [pve-devel] [PATCH proxmox-firewall/ve-rs v2 0/3] Fix ICMP types in nftables Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006101933.90655-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.