From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager v2 2/2] ui: fix #6209: create snapshots and backups from context menu
Date: Thu, 2 Oct 2025 17:16:09 +0200 [thread overview]
Message-ID: <20251002151609.41473-3-n.frey@proxmox.com> (raw)
In-Reply-To: <20251002151609.41473-1-n.frey@proxmox.com>
Adds snapshot and manual backup shortcut to VM/CT right-click context
menu.
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6209
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
| 47 ++++++++++++++++++++++++++++++++++++
| 47 ++++++++++++++++++++++++++++++++++++
2 files changed, 94 insertions(+)
--git a/www/manager6/lxc/CmdMenu.js b/www/manager6/lxc/CmdMenu.js
index cd60c967..bd5fe164 100644
--- a/www/manager6/lxc/CmdMenu.js
+++ b/www/manager6/lxc/CmdMenu.js
@@ -134,6 +134,40 @@ Ext.define('PVE.lxc.CmdMenu', {
},
},
{ xtype: 'menuseparator' },
+ {
+ text: gettext('Take Snapshot'),
+ iconCls: 'fa fa-fw fa-history',
+ itemId: 'takeSnapshotBtn',
+ disabled: true, // default until async check finishes
+ handler: function () {
+ let win = Ext.create('PVE.window.Snapshot', {
+ nodename: info.node,
+ vmid: info.vmid,
+ vmname: info.name,
+ viewonly: false,
+ type: info.type,
+ isCreate: true,
+ submitText: gettext('Take Snapshot'),
+ running: running,
+ });
+ win.show();
+ },
+ },
+ {
+ text: gettext('Backup now'),
+ iconCls: 'fa fa-fw fa-floppy-o',
+ disabled: !caps.vms['VM.Backup'],
+ handler: function () {
+ var win = Ext.create('PVE.window.Backup', {
+ nodename: info.node,
+ vmid: info.vmid,
+ vmtype: info.type,
+ vmname: info.name,
+ });
+ win.show();
+ },
+ },
+ { xtype: 'menuseparator' },
{
text: gettext('Console'),
iconCls: 'fa fa-fw fa-terminal',
@@ -149,5 +183,18 @@ Ext.define('PVE.lxc.CmdMenu', {
];
me.callParent();
+
+ Proxmox.Utils.API2Request({
+ url: `/nodes/${info.node}/${info.type}/${info.vmid}/feature`,
+ params: { feature: 'snapshot' },
+ method: 'GET',
+ success: function (response) {
+ let hasFeature = !!response.result.data.hasFeature;
+ let btn = me.down('#takeSnapshotBtn');
+ if (btn) {
+ btn.setDisabled(!(caps.vms['VM.Snapshot'] && hasFeature));
+ }
+ },
+ });
},
});
--git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js
index adf64672..7c9080c5 100644
--- a/www/manager6/qemu/CmdMenu.js
+++ b/www/manager6/qemu/CmdMenu.js
@@ -169,6 +169,40 @@ Ext.define('PVE.qemu.CmdMenu', {
},
},
{ xtype: 'menuseparator' },
+ {
+ text: gettext('Take Snapshot'),
+ iconCls: 'fa fa-fw fa-history',
+ itemId: 'takeSnapshotBtn',
+ disabled: true,
+ handler: function () {
+ let win = Ext.create('PVE.window.Snapshot', {
+ nodename: info.node,
+ vmid: info.vmid,
+ vmname: info.name,
+ viewonly: false,
+ type: info.type,
+ isCreate: true,
+ submitText: gettext('Take Snapshot'),
+ running: running,
+ });
+ win.show();
+ },
+ },
+ {
+ text: gettext('Backup now'),
+ iconCls: 'fa fa-fw fa-floppy-o',
+ disabled: !caps.vms['VM.Backup'],
+ handler: function () {
+ var win = Ext.create('PVE.window.Backup', {
+ nodename: info.node,
+ vmid: info.vmid,
+ vmtype: info.type,
+ vmname: info.name,
+ });
+ win.show();
+ },
+ },
+ { xtype: 'menuseparator' },
{
text: gettext('Console'),
iconCls: 'fa fa-fw fa-terminal',
@@ -194,5 +228,18 @@ Ext.define('PVE.qemu.CmdMenu', {
];
me.callParent();
+
+ Proxmox.Utils.API2Request({
+ url: `/nodes/${info.node}/${info.type}/${info.vmid}/feature`,
+ params: { feature: 'snapshot' },
+ method: 'GET',
+ success: function (response) {
+ let hasFeature = !!response.result.data.hasFeature;
+ let btn = me.down('#takeSnapshotBtn');
+ if (btn) {
+ btn.setDisabled(!(caps.vms['VM.Snapshot'] && hasFeature));
+ }
+ },
+ });
},
});
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-02 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 15:16 [pve-devel] [PATCH pve-manager v2 0/2] " Nicolas Frey
2025-10-02 15:16 ` [pve-devel] [PATCH pve-manager v2 1/2] ui: guest snapshot: remove excess '}' at the end of window title Nicolas Frey
2025-10-03 17:31 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-02 15:16 ` Nicolas Frey [this message]
2025-10-03 14:01 ` [pve-devel] [PATCH pve-manager v2 0/2] ui: fix #6209: create snapshots and backups from context menu Shan Shaji
2025-10-07 8:56 ` Nicolas Frey
[not found] <89366ef9-275a-46ef-b639-9b9d056f0d8e@proxmox.com>
2025-10-07 9:03 ` [pve-devel] [PATCH pve-manager v2 2/2] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002151609.41473-3-n.frey@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.