all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/2] fix possible deadlock for S3 garbage
Date: Thu,  2 Oct 2025 11:11:40 +0200	[thread overview]
Message-ID: <20251002091142.222897-1-c.ebner@proxmox.com> (raw)

The first patch fixes a possible deadlock situation:
Holding a std::sync::Mutex guard across .await boundaries can lead to
deadlock situations and must be avoided by all costs. Fix one such
ocurence when deleting objects from S3 object stores while still
holding the lock.

The second patch adapts an ill-chosen method name and incorrect
comment.

These patches are followups to be applied on top of:
https://lore.proxmox.com/pbs-devel/20251001111915.2001026-1-f.gruenbichler@proxmox.com/T/

Christian Ebner (2):
  datastore: gc: drop mutex lock before entering async context
  datastore: gc: rename method and adapt incorrect comments

 pbs-datastore/src/datastore.rs | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-10-02  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  9:11 Christian Ebner [this message]
2025-10-02  9:11 ` [pbs-devel] [PATCH proxmox-backup 1/2] datastore: gc: drop mutex lock before entering async context Christian Ebner
2025-10-02  9:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] datastore: gc: rename method and adapt incorrect comments Christian Ebner
2025-10-02 12:18   ` Fabian Grünbichler
2025-10-02 12:32     ` Christian Ebner
2025-10-02 12:15 ` [pbs-devel] partially-applied: [PATCH proxmox-backup 0/2] fix possible deadlock for S3 garbage Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002091142.222897-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal