From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 0/3] rework GC-related locks
Date: Thu, 2 Oct 2025 09:27:45 +0200 [thread overview]
Message-ID: <20251002072843.88042-1-f.gruenbichler@proxmox.com> (raw)
this series reworks some of the locking behaviour surrounding GC.
the first patch removes a potentially problematic combination of
std::sync::Mutex and async S3 code (this should be the last such code
path), by storing the ProcessLocker guard inside the mutex while holding
it just for storing/querying/dropping that guard, instead of for the
duration of GC.
the second and third patches get rid of racy interactions between
pre-reload backup sessions and post-reload GC tasks. while this race
doesn't lead to data loss, it breaks the expected priority of such
tasks.
v2: rework first patch to keep locking the Mutex first
Fabian Grünbichler (3):
GC: rework locking logic
backup env: keep a shared chunk store lock for duration of backup
index writers: remove chunk store lock
pbs-datastore/src/datastore.rs | 527 +++++++++++++++--------------
pbs-datastore/src/dynamic_index.rs | 6 +-
pbs-datastore/src/fixed_index.rs | 6 +-
src/api2/backup/environment.rs | 5 +
src/api2/backup/mod.rs | 4 +-
5 files changed, 285 insertions(+), 263 deletions(-)
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-10-02 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 7:27 Fabian Grünbichler [this message]
2025-10-02 7:27 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] GC: rework locking logic Fabian Grünbichler
2025-10-02 7:27 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] backup env: keep a shared chunk store lock for duration of backup Fabian Grünbichler
2025-10-02 7:27 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] index writers: remove chunk store lock Fabian Grünbichler
2025-10-02 9:22 ` [pbs-devel] [PATCH proxmox-backup v2 0/3] rework GC-related locks Christian Ebner
2025-10-02 12:10 ` [pbs-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002072843.88042-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.