From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_dart_api_client] fix: ios: add type check to catch `NSErrorClientException`
Date: Wed, 1 Oct 2025 11:52:31 +0200 [thread overview]
Message-ID: <20251001095231.4458-1-s.shaji@proxmox.com> (raw)
The `NSErrorClientException` catch clause was not being executed because
it's a subtype of `ClientException`. This resulted in showing the
actual error from the package instead of our custom error message when
the SSL/TLS handshake failed. Fixed the issue by adding a type check
inside the `ClientException` catch clause.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
lib/src/authenticate.dart | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart
index 04f363f..aaae50b 100644
--- a/lib/src/authenticate.dart
+++ b/lib/src/authenticate.dart
@@ -61,12 +61,12 @@ Future<ProxmoxApiClient> authenticate(
if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) {
throw HandshakeException(e.message);
}
- rethrow;
- } on NSErrorClientException catch (e) {
+
// Treat untrusted server certificate (-1202) as a handshake failure.
- if (e.error.code == -1202) {
+ if (e is NSErrorClientException && e.error.code == -1202) {
throw HandshakeException(e.message);
}
+
rethrow;
}
}
@@ -91,12 +91,12 @@ Future<List<PveAccessDomainModel?>> accessDomains(
if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) {
throw HandshakeException(e.message);
}
- rethrow;
- } on NSErrorClientException catch (e) {
+
// Treat untrusted server certificate (-1202) as a handshake failure.
- if (e.error.code == -1202) {
+ if (e is NSErrorClientException && e.error.code == -1202) {
throw HandshakeException(e.message);
}
+
rethrow;
}
}
--
2.50.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-10-01 9:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001095231.4458-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.